1650963 - "Separate Window" or "Dock to Blah" doesn't work in newly opened non-Fission browser window

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

Steps to reproduce

1. Launch Firefox with enabling Fission
2. Open a new non-Fission window
3. Open the inspector on the new window
4. Separate the inspector window or (Dock to somewhere)

There appears a blank window (or blank region if you choose Dock to).

Comment 1

[Chris Peterson [:cpeterson]]

This bug probably doesn't need to block shipping the Fission MVP if it only happens in non-Fission windows when Fission is enabled. Opening non-Fission windows is a testing feature, not an officially supported configuration.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

I agree, opening non-Fission window is not a big deal. What I am concerned is that features don't work in non-Fission window (even with Fission window) are quite odd. There may be a serial root cause, I think someone should take a look to see what causes this issue.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:Honza, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Chris Peterson [:cpeterson]]

Adding dt-fission whiteboard tag to DevTools bugs that mention Fission or block Fission meta bugs but don't already have a dt-fission whiteboard tag.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can reproduce this problem on my machine (Win 10 + the current Nightly)

I am seeing the following error in the Browser Console
NS_ERROR_NOT_IMPLEMENTED toolbox-host-manager.js:237

The error points to famous swapFrameLoaders
https://searchfox.org/mozilla-central/rev/ac142717cc067d875e83e4b1316f004f6e063a46/devtools/client/framework/toolbox-host-manager.js#237``

Alex, any ideas here?

Honza

Comment 7

[Julian Descottes [:jdescottes]]

Need to pass non-fission flag when creating the frame for the new devtools window.

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1650963 - [devtools] Set non-fission flag when opening DevTools window from a non-fission host tab

We cannot use swapFrameLoaders between a fission and a non fission window. We should make sure to open non-fission windows if the current host is not a fission one.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7363a707fce6
[devtools] Set non-fission flag when opening DevTools window from a non-fission host tab r=Honza

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7363a707fce6