Closed Bug 1651038 Opened 5 years ago Closed 4 years ago

Intermittent Assertion failure: aElement->HasServoData() (Element without Servo data on a post-traversal? How?), at /builds/worker/checkouts/gecko/layout/base/RestyleManager.cpp:2584

Categories

(Core :: Layout, defect, P5)

defect

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- wontfix
firefox87 --- wontfix
firefox88 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: emilio)

Details

(Keywords: assertion, intermittent-failure, Whiteboard: [stockwell unknown], [wptsync upstream])

Attachments

(3 files)

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=308810138&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/MmYQAP5VSV6lU_1r8JYo-Q/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/MmYQAP5VSV6lU_1r8JYo-Q/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1


[task 2020-07-07T10:54:12.447Z] 10:54:12 INFO - REFTEST TEST-PASS | docshell/base/crashtests/1257730-1.html | (LOAD ONLY)
[task 2020-07-07T10:54:12.448Z] 10:54:12 INFO - REFTEST TEST-END | docshell/base/crashtests/1257730-1.html
[task 2020-07-07T10:54:12.449Z] 10:54:12 INFO - Assertion failure: aElement->HasServoData() (Element without Servo data on a post-traversal? How?), at /builds/worker/checkouts/gecko/layout/base/RestyleManager.cpp:2584
[task 2020-07-07T10:54:12.450Z] 10:54:12 INFO - #01: mozilla::RestyleManager::ProcessPostTraversal(mozilla::dom::Element*, mozilla::ServoRestyleState&, mozilla::ServoPostTraversalFlags) [layout/base/RestyleManager.cpp:2801]
[task 2020-07-07T10:54:12.450Z] 10:54:12 INFO - #02: mozilla::RestyleManager::DoProcessPendingRestyles(mozilla::ServoTraversalFlags) [layout/base/RestyleManager.cpp:3007]
[task 2020-07-07T10:54:12.451Z] 10:54:12 INFO - #03: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) [layout/base/PresShell.cpp:4198]
[task 2020-07-07T10:54:12.451Z] 10:54:12 INFO - #04: nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/PresShell.h:0]
[task 2020-07-07T10:54:12.451Z] 10:54:12 INFO - #05: mozilla::RefreshDriverTimer::TickRefreshDrivers(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp, nsTArray<RefPtr<nsRefreshDriver> >&) [layout/base/nsRefreshDriver.cpp:344]
[task 2020-07-07T10:54:12.452Z] 10:54:12 INFO - #06: mozilla::RefreshDriverTimer::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:369]
[task 2020-07-07T10:54:12.453Z] 10:54:12 INFO - #07: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:739]
[task 2020-07-07T10:54:12.453Z] 10:54:12 INFO - #08: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyParentProcessVsync() [layout/base/nsRefreshDriver.cpp:640]
[task 2020-07-07T10:54:12.454Z] 10:54:12 INFO - #09: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::ParentProcessVsyncNotifier::Run() [layout/base/nsRefreshDriver.cpp:539]
[task 2020-07-07T10:54:12.455Z] 10:54:12 INFO - #10: mozilla::RunnableTask::Run() [xpcom/threads/TaskController.cpp:210]
[task 2020-07-07T10:54:12.455Z] 10:54:12 INFO - #11: mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:459]
[task 2020-07-07T10:54:12.456Z] 10:54:12 INFO - #12: mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:338]
[task 2020-07-07T10:54:12.456Z] 10:54:12 INFO - #13: mozilla::TaskController::ProcessPendingMTTask() [xpcom/threads/TaskController.cpp:154]
[task 2020-07-07T10:54:12.457Z] 10:54:12 INFO - #14: mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_4>::Run() [xpcom/threads/nsThreadUtils.h:578]
[task 2020-07-07T10:54:12.457Z] 10:54:12 INFO - #15: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1236]
[task 2020-07-07T10:54:12.457Z] 10:54:12 INFO - #16: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:513]
[task 2020-07-07T10:54:12.458Z] 10:54:12 INFO - #17: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:87]
[task 2020-07-07T10:54:12.458Z] 10:54:12 INFO - #18: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:334]
[task 2020-07-07T10:54:12.460Z] 10:54:12 INFO - #19: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:310]
[task 2020-07-07T10:54:12.460Z] 10:54:12 INFO - #20: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:139]
[task 2020-07-07T10:54:12.460Z] 10:54:12 INFO - #21: XRE_RunAppShell() [toolkit/xre/nsEmbedFunctions.cpp:913]
[task 2020-07-07T10:54:12.461Z] 10:54:12 INFO - #22: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:237]
[task 2020-07-07T10:54:12.461Z] 10:54:12 INFO - #23: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:334]
[task 2020-07-07T10:54:12.462Z] 10:54:12 INFO - #24: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:310]
[task 2020-07-07T10:54:12.463Z] 10:54:12 INFO - #25: XRE_InitChildProcess(int, char**, XREChildData const*) [toolkit/xre/nsEmbedFunctions.cpp:744]
[task 2020-07-07T10:54:12.464Z] 10:54:12 INFO - #26: content_process_main(mozilla::Bootstrap*, int, char**) [ipc/contentproc/plugin-container.cpp:57]
[task 2020-07-07T10:54:12.464Z] 10:54:12 INFO - #27: main [browser/app/nsBrowserApp.cpp:303]
[task 2020-07-07T10:54:12.464Z] 10:54:12 INFO - #28: __libc_start_main [/lib/x86_64-linux-gnu/libc.so.6 + 0x21b97]
[task 2020-07-07T10:54:12.465Z] 10:54:12 INFO - #29: ??? [/builds/worker/workspace/build/application/firefox/firefox-bin + 0x10ac9]
[task 2020-07-07T10:54:12.465Z] 10:54:12 INFO - #30: ??? (???:???)
[task 2020-07-07T10:54:12.466Z] 10:54:12 INFO - [Parent 1169, Breakpad Server] WARNING: Resource acquired is being released in non-LIFO order; why?
[task 2020-07-07T10:54:12.466Z] 10:54:12 INFO - : file /builds/worker/checkouts/gecko/xpcom/threads/BlockingResourceBase.cpp, line 292
[task 2020-07-07T10:54:12.466Z] 10:54:12 INFO - --- Mutex : dumpSafetyLock (currently acquired)
[task 2020-07-07T10:54:12.467Z] 10:54:12 INFO - calling context
[task 2020-07-07T10:54:12.467Z] 10:54:12 INFO - [stack trace unavailable]

This is a new frequent failure and needs investigation what started it.

Flags: needinfo?(svoisen)

Bug 1650510 is a test-only change, and those tests don't run in the suite that fails here (they are devtools mochitests).
It's very unlikely to be related, I think we should do more retriggers here.

I also see failures on earlier pushes, eg https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=RhkJX3rEQeS71Q9qfGVrWA.0&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Creftests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-crashtest-fis-e10s%2Cc&revision=e60508a2639b6256c0d97c8b2a5a89eb68f848f3

Might be related to Bug 1630704 which modified RestyleManager.cpp ?

Flags: needinfo?(jdescottes)

Emilio: Thoughts on this? Bug 1630704?

Flags: needinfo?(svoisen) → needinfo?(emilio)

Doubtful, that shouldn't have any behavior change. The initial stack includes the new scheduler so there may be the case that that caused it. Given this repros across platforms, is there any chance we can see a pernosco recording of this? I'd be interested innpoking at this.

Alternatively can we do a couple more retriggers?

Flags: needinfo?(emilio)

In the last 7 days there have been 24 occurrences, most on linux1804-64 debug and opt.

Recent failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311726261&repo=mozilla-central&lineNumber=1836

Whiteboard: [stockwell needswork]

In the last 7 days there have been 23 occurrences on linux1804-64 and macosx1014-64 build types debug and opt.

Recent failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313053320&repo=autoland&lineNumber=1627

Sean, could you, please, take a look?

Flags: needinfo?(svoisen)
Whiteboard: [stockwell unknown] → [stockwell needswork:owner]

I've checked the last 10 logs and this occurs after:
[task 2020-10-23T08:25:01.101Z] 08:25:01 INFO - REFTEST TEST-START | docshell/base/crashtests/1257730-1.html

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319217000&repo=mozilla-central&lineNumber=2452

[task 2020-10-21T04:21:50.127Z] 04:21:50 INFO - REFTEST TEST-START | docshell/base/crashtests/1257730-1.html
[task 2020-10-21T04:21:50.127Z] 04:21:50 INFO - REFTEST INFO | RESTORE PREFERENCE pref(dom.disable_open_during_load,true)
[task 2020-10-21T04:21:50.127Z] 04:21:50 INFO - REFTEST INFO | SET PREFERENCE pref(browser.send_pings,true)
[task 2020-10-21T04:21:50.127Z] 04:21:50 INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/reftest/tests/docshell/base/crashtests/1257730-1.html | 34 / 3856 (0%)
[task 2020-10-21T04:21:50.132Z] 04:21:50 INFO - REFTEST TEST-PASS | docshell/base/crashtests/1257730-1.html | (LOAD ONLY)
[task 2020-10-21T04:21:50.132Z] 04:21:50 INFO - REFTEST TEST-END | docshell/base/crashtests/1257730-1.html
[task 2020-10-21T04:21:50.134Z] 04:21:50 INFO - Assertion failure: aElement->HasServoData() (Element without Servo data on a post-traversal? How?), at /builds/worker/checkouts/gecko/layout/base/RestyleManager.cpp:2583
[task 2020-10-21T04:21:50.134Z] 04:21:50 INFO - #01: mozilla::RestyleManager::ProcessPostTraversal(mozilla::dom::Element*, mozilla::ServoRestyleState&, mozilla::ServoPostTraversalFlags) [layout/base/RestyleManager.cpp:2800]
[task 2020-10-21T04:21:50.134Z] 04:21:50 INFO - #02: mozilla::RestyleManager::DoProcessPendingRestyles(mozilla::ServoTraversalFlags) [layout/base/RestyleManager.cpp:3006]
[task 2020-10-21T04:21:50.134Z] 04:21:50 INFO - #03: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) [layout/base/PresShell.cpp:4184]
[task 2020-10-21T04:21:50.135Z] 04:21:50 INFO - #04: nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:2197]
[task 2020-10-21T04:21:50.135Z] 04:21:50 INFO - #05: mozilla::RefreshDriverTimer::TickRefreshDrivers(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp, nsTArray<RefPtr<nsRefreshDriver> >&) [layout/base/nsRefreshDriver.cpp:347]
[task 2020-10-21T04:21:50.135Z] 04:21:50 INFO - #06: mozilla::RefreshDriverTimer::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:370]
[task 2020-10-21T04:21:50.137Z] 04:21:50 INFO - #07: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:749]
[task 2020-10-21T04:21:50.137Z] 04:21:50 INFO - #08: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyParentProcessVsync() [layout/base/nsRefreshDriver.cpp:650]
[task 2020-10-21T04:21:50.137Z] 04:21:50 INFO - #09: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyVsync(mozilla::VsyncEvent const&) [layout/base/nsRefreshDriver.cpp:570]
[task 2020-10-21T04:21:50.137Z] 04:21:50 INFO - #10: mozilla::layout::VsyncChild::RecvNotify(mozilla::VsyncEvent const&) [layout/ipc/VsyncChild.cpp:57]
[task 2020-10-21T04:21:50.138Z] 04:21:50 INFO - #11: mozilla::layout::PVsyncChild::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources:dcfb0c5c8cc64a4b8592c33a9bb2c1a430c98ebd009674a59f93629a7c17a7323253973267a429964267d5e17f515a9e0c9f5ab4ceb87eda82e2dd117c395600/ipc/ipdl/PVsyncChild.cpp::187]
[task 2020-10-21T04:21:50.138Z] 04:21:50 INFO - #12: mozilla::ipc::PBackgroundChild::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources:6d2e160d458a876379d79ad4e64e8a33e9758fbaa3dc353140531b3d7521e7ee52f6b8637c2f4e39bd439aa125d19781c1c523a6a2f78b752637dfb8b696677e/ipc/ipdl/PBackgroundChild.cpp::6231]
[task 2020-10-21T04:21:50.138Z] 04:21:50 INFO - #13: mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) [ipc/glue/MessageChannel.cpp:2151]
[task 2020-10-21T04:21:50.138Z] 04:21:50 INFO - #14: mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) [ipc/glue/MessageChannel.cpp:2077]
[task 2020-10-21T04:21:50.140Z] 04:21:50 INFO - #15: mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) [ipc/glue/MessageChannel.cpp:1922]
[task 2020-10-21T04:21:50.140Z] 04:21:50 INFO - #16: mozilla::ipc::MessageChannel::MessageTask::Run() [ipc/glue/MessageChannel.cpp:1955]
[task 2020-10-21T04:21:50.140Z] 04:21:50 INFO - #17: mozilla::RunnableTask::Run() [xpcom/threads/TaskController.cpp:246]
[task 2020-10-21T04:21:50.140Z] 04:21:50 INFO - #18: mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:515]
[task 2020-10-21T04:21:50.141Z] 04:21:50 INFO - #19: mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:374]
[task 2020-10-21T04:21:50.141Z] 04:21:50 INFO - #20: mozilla::TaskController::ProcessPendingMTTask(bool) [xpcom/threads/TaskController.cpp:171]
[task 2020-10-21T04:21:50.141Z] 04:21:50 INFO - #21: mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_3>::Run() [xpcom/threads/nsThreadUtils.h:578]
[task 2020-10-21T04:21:50.141Z] 04:21:50 INFO - #22: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1200]
[task 2020-10-21T04:21:50.141Z] 04:21:50 INFO - #23: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:513]
[task 2020-10-21T04:21:50.143Z] 04:21:50 INFO - #24: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:87]
[task 2020-10-21T04:21:50.143Z] 04:21:50 INFO - #25: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:334]
[task 2020-10-21T04:21:50.143Z] 04:21:50 INFO - #26: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:310]
[task 2020-10-21T04:21:50.143Z] 04:21:50 INFO - #27: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:139]
[task 2020-10-21T04:21:50.143Z] 04:21:50 INFO - #28: XRE_RunAppShell() [toolkit/xre/nsEmbedFunctions.cpp:913]
[task 2020-10-21T04:21:50.143Z] 04:21:50 INFO - #29: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:237]
[task 2020-10-21T04:21:50.145Z] 04:21:50 INFO - #30: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:334]
[task 2020-10-21T04:21:50.145Z] 04:21:50 INFO - #31: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:310]
[task 2020-10-21T04:21:50.145Z] 04:21:50 INFO - #32: XRE_InitChildProcess(int, char**, XREChildData const*) [toolkit/xre/nsEmbedFunctions.cpp:744]
[task 2020-10-21T04:21:50.145Z] 04:21:50 INFO - #33: content_process_main(mozilla::Bootstrap*, int, char**) [ipc/contentproc/plugin-container.cpp:57]
[task 2020-10-21T04:21:50.146Z] 04:21:50 INFO - #34: main [browser/app/nsBrowserApp.cpp:304]
[task 2020-10-21T04:21:50.146Z] 04:21:50 INFO - #35: __libc_start_main [/lib/x86_64-linux-gnu/libc.so.6 + 0x21b97]
[task 2020-10-21T04:21:50.146Z] 04:21:50 INFO - #36: ??? [/builds/worker/workspace/build/application/firefox/firefox-bin + 0x3f7c9]
[task 2020-10-21T04:21:50.146Z] 04:21:50 INFO - #37: ??? (???:???)
[task 2020-10-21T04:21:50.146Z] 04:21:50 INFO - [Parent 1406, Breakpad Server] WARNING: Resource acquired is being released in non-LIFO order; why?
[task 2020-10-21T04:21:50.146Z] 04:21:50 INFO - : file /builds/worker/checkouts/gecko/xpcom/threads/BlockingResourceBase.cpp:292
[task 2020-10-21T04:21:50.148Z] 04:21:50 INFO - --- Mutex : dumpSafetyLock (currently acquired)
[task 2020-10-21T04:21:50.148Z] 04:21:50 INFO - calling context
[task 2020-10-21T04:21:50.148Z] 04:21:50 INFO - [stack trace unavailable]
[task 2020-10-21T04:21:50.148Z] 04:21:50 INFO - [Parent 1406, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:511
[task 2020-10-21T04:21:50.148Z] 04:21:50 INFO - [Parent 1406, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:511
[task 2020-10-21T04:21:50.150Z] 04:21:50 INFO - [Parent 1406, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:511
[task 2020-10-21T04:21:50.150Z] 04:21:50 INFO - [Parent 1406, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:511
[task 2020-10-21T04:21:50.150Z] 04:21:50 INFO - [Parent 1406, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:511
[task 2020-10-21T04:21:50.150Z] 04:21:50 INFO - [Parent 1406, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:511
[task 2020-10-21T04:21:50.152Z] 04:21:50 INFO - [Parent 1406, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:511
[task 2020-10-21T04:21:50.152Z] 04:21:50 INFO - [Parent 1406, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:511
[task 2020-10-21T04:21:50.152Z] 04:21:50 INFO - [Parent 1406, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:511
[task 2020-10-21T04:21:50.152Z] 04:21:50 INFO - [Parent 1406, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:511
[task 2020-10-21T04:21:50.152Z] 04:21:50 INFO - [Parent 1406, Compositor] WARNING: bad Shmem: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:470
[task 2020-10-21T04:21:50.153Z] 04:21:50 INFO - [Parent 1406, Compositor] WARNING: bad Shmem: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:470
[task 2020-10-21T04:21:50.153Z] 04:21:50 INFO - [Parent 1406, Compositor] WARNING: bad Shmem: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:470
[task 2020-10-21T04:21:50.153Z] 04:21:50 ERROR - A content process crashed and MOZ_CRASHREPORTER_SHUTDOWN is set, shutting down
[task 2020-10-21T04:21:50.153Z] 04:21:50 INFO - [Parent 1406, Compositor] WARNING: Possibly dropping task posted to updater thread: file /builds/worker/checkouts/gecko/gfx/layers/apz/src/APZUpdater.cpp:370
[task 2020-10-21T04:21:50.155Z] 04:21:50 INFO - [Parent 1406, Compositor] WARNING: Possibly dropping task posted to updater thread: file /builds/worker/checkouts/gecko/gfx/layers/apz/src/APZUpdater.cpp:370
[task 2020-10-21T04:21:50.155Z] 04:21:50 INFO - [Parent 1406, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorProtocol.cpp:172
[task 2020-10-21T04:21:50.155Z] 04:21:50 INFO - [Parent 1406, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorProtocol.cpp:172
[task 2020-10-21T04:21:50.155Z] 04:21:50 INFO - [Parent 1406, Compositor] WARNING: Possibly dropping task posted to updater thread: file /builds/worker/checkouts/gecko/gfx/layers/apz/src/APZUpdater.cpp:370
[task 2020-10-21T04:21:50.155Z] 04:21:50 INFO - ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2020-10-21T04:21:50.156Z] 04:21:50 INFO - [2020-10-21T04:21:46Z WARN xulstore::persist] tried to remove key that isn't in the store
[task 2020-10-21T04:21:50.156Z] 04:21:50 INFO - [2020-10-21T04:21:46Z WARN xulstore::persist] tried to remove key that isn't in the store
[task 2020-10-21T04:21:50.156Z] 04:21:50 INFO - [Parent 1406, Main Thread] WARNING: 'aOwner->IsDiscarded()', file /builds/worker/workspace/obj-build/dist/include/mozilla/dom/SyncedContextInlines.h:36
[task 2020-10-21T04:21:50.156Z] 04:21:50 INFO - !!! error running onStopped callback: TypeError: callback is not a function

Sean are you working on this?

Flags: needinfo?(svoisen)
Flags: needinfo?(svoisen)
Whiteboard: [stockwell unknown] → [stockwell needswork:owner]
Flags: needinfo?(sean)

There were 57 total failures in the last 7 days:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2021-02-06&endday=2021-02-13&tree=trunk&bug=1651038
Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=329865406&repo=autoland&lineNumber=2481

Affected platforms are:

  • windows7-32 debug
  • windows10-64 asan
  • macosx1014-64 debug
  • linux1804-64-qr debug
  • linux1804-64-asan-qr and linux1804-64-asan
  • linux1804-64 debug
Whiteboard: [stockwell unknown] → [stockwell needswork:owner]

Hi Daniel, can you take a look or assign someone to? Thank you in advance.

Flags: needinfo?(dholbert)

Emilio, maybe you could take a look? Looks like you'd expressed some interest in comment 7. Thanks!

Flags: needinfo?(dholbert) → needinfo?(emilio)

Yes, I'm in fact interested, but it doesn't seem there is any sort of reproducer that I could look at? Andreea, do you know which tests usually fail like this? Maybe I could leave some of them running and I could get a pernosco / rr recording. Otherwise this is not particularly actionable. We could downgrade the assert but that'd make the bug even harder to catch...

Jason, do you know if any of the fuzzers may have a repro for this?

Flags: needinfo?(jkratzer)
Flags: needinfo?(emilio)
Flags: needinfo?(apavel)

Hi!
Last 7 days we have like this:

  • linux1804-64-asan-qr: 92788-; 1.html; 1511130.html; 1257730-1.html;
  • windows10-64 asan & debug: 1257730-1.html; 1003441.xhtml;
  • windows7-32 debug: 1257730-1.html; 1003441.xhtml;

Majority of failures on each platform is on docshell/base/crashtests/1257730-1.html, same as the first failure reported.
Let me know if you need me to look on a larger period of time.

Flags: needinfo?(apavel)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #46)

Yes, I'm in fact interested, but it doesn't seem there is any sort of reproducer that I could look at? Andreea, do you know which tests usually fail like this? Maybe I could leave some of them running and I could get a pernosco / rr recording. Otherwise this is not particularly actionable. We could downgrade the assert but that'd make the bug even harder to catch...

Jason, do you know if any of the fuzzers may have a repro for this?

Unfortunately not. The closest crash we have to that signature was filed in bug 1462401. However, that testcase no longer reproduces and the last crash for that signature was seen on 2019-01-20.

Flags: needinfo?(jkratzer)

Looks like I spoke too soon. I managed to get a pernosco session for this issue. You can find it here:
https://pernos.co/debug/BUvPrCCUEf7vdiAvYrhJzg/index.html

Flags: needinfo?(emilio)
Attached file testcase.zip

The attached testcase cane be reproduced using grizzly[1]:

  1. pip install grizzly-framework
  2. unzip testcase.zip -d testcase-dir
  3. python3 -m grizzly.replay --xvfb --repeat 10 ~/builds/mc-debug/firefox ./testcase-dir

[1] https://github.com/MozillaSecurity/grizzly

Attached file Test-case from Jason

Beautiful. Here's the test-case slightly simplified. That's more than enough to crash Nightly for me. Digging now. Off hand it seems like an XML parser bug/issue, because .innerHTML triggers an unexpected flush from the parser itself...

As it won't after that if something flushes (because
FlushPendingNotifications will just ignore the flush if the sink is no
longer a document observer).

Otherwise we might not notify of some document insertions, and that
might reasonably confuse layout if it has started before.

The reason we don't have more similar crashes seems to be two different
things:

Assignee: nobody → emilio
Status: NEW → ASSIGNED

Jason, thanks so so much for the test-case!

Flags: needinfo?(emilio)

James, wpt lint complains it can't parse the file, but that's kind of the point (this bug happens partially because the test-case doesn't contain trailing closing tags). Do you know where can I annotate it?

Flags: needinfo?(james)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b6cdff635c85 nsXMLContentSink::DidBuildModel should flush pending tags. r=hsivonen
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27993 for changes under testing/web-platform/tests
Whiteboard: [stockwell unknown] → [stockwell unknown], [wptsync upstream]
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: