1651093 - Add the three tiles on new tab to UserMessaging policy

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, enhancement, P5)

Description

[Mike Kaply [:mkaply]]

Currently we turn off the three tiles on new tab if a welcome page is set or if you turn off Firefox accounts.

We should have an explicit policy for this as well as it is confusing folks.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1651093 - Update UserMessaging policy for triplets. r?pdahiya

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4186bb32c30
Update UserMessaging policy for triplets. r=pdahiya

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c4186bb32c30

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 9163273 [details]
Bug 1651093 - Update UserMessaging policy for triplets. r?pdahiya

Beta/Release Uplift Approval Request

• User impact if declined: Triplets display even though policy says not to.
  No way to explicitly turn off triplets.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open Firefox, notice that there are triplets on newtab/welcome.
  Set the policies for either overriding the first run page, disabling Firefox accounts or the new usermessaging->SkipOnboarding and verify the triplets don't show.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only. We're trying to write a test, but having trouble.
• String changes made/needed:

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy related
• User impact if declined: Triplets display even though policy says not to.
  No way to explicitly turn off triplets.
• Fix Landed on Version: 80
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only. We're trying to write a test, but having trouble.
• String or UUID changes made by this patch:

Comment 5

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

Comment on attachment 9163273 [details]
Bug 1651093 - Update UserMessaging policy for triplets. r?pdahiya

Approved for 79.0b9 and 78.1esr.

Comment 6

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a7136eba9635

Comment 7

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/bdbddeb365ed

Comment 8

[Peter Magyari (Desktop QA)]

Verified fixed on Nightly 80.0a1 (20200717093907), Beta 79.0b9 (20200717001501) and Firefox ESR 78.1.0 (20200716223031)

Comment 9

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #26544 (as of Fri, 17 Jul 2020 18:16:43 GMT) ==

Improvements:

3% build times windows2012-64 debug plain taskcluster-c4.4xlarge 2,470.03 -> 2,397.46

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26544