1651154 - Video playheads visible on dev tools

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Gavin Suntop [:gvn] (they/them)]

Repro steps:

• Set browser.newtabpage.activity-stream.discoverystream.config to { "api_key_pref": "extensions.pocket.oAuthConsumerKey", "collapsible": true, "enabled": true, "show_spocs": true, "hardcoded_layout": false, "personalized": true, "layout_endpoint": "https://getpocket.cdn.mozilla.net/v3/newtab/layout?version=1&consumer_key=$apiKey&layout_variant=video-layout", "unused_key": "unused_4" }
• Set browser.newtabpage.activity-stream.discoverystream.spocs-endpoint to https://spocs.getpocket.com/spocs?site=1124115
• Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
• Open about:home#devtools

Expected: See no video playheads visible inside of dev tools

Actual: Seeing floating video playheads (see pic)

Comment 1

[Gavin Suntop [:gvn] (they/them)]

Attachment: image.png

Comment 2

[Gavin Suntop [:gvn] (they/them)]

Seems like cards are still loaded in the DOM and playhead z-index is causing them to float on top.

Comment 3

[Gavin Suntop [:gvn] (they/them)]

Attachment: Bug 1651154 - hiding video playhead from dev tools

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a20c3373cb7
hiding video playhead from dev tools r=thecount

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7a20c3373cb7

Comment 6

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the Video playheads are no longer visible in "about:home#devtools" by doing the following:

• Set the value of the browser.newtabpage.activity-stream.discoverystream.config pref to {"api_key_pref": "extensions.pocket.oAuthConsumerKey", "collapsible": true, "enabled": true, "show_spocs": true, "hardcoded_layout": false, "personalized": true, "layout_endpoint": "https://getpocket.cdn.mozilla.net/v3/newtab/layout?version=1&consumer_key=$apiKey&layout_variant=video-layout", "unused_key": "unused_4"}
• Set the value of the browser.newtabpage.activity-stream.asrouter.devtoolsEnabled pref to true
• Set the value of the browser.search.region pref to US
• Set the value of the browser.newtabpage.activity-stream.discoverystream.spocs-endpoint pref to https://e5e8374d-fffa-4a77-a604-31603852b6fd.mock.pstmn.io/1635278/spocs
• Set the value of the browser.newtabpage.activity-stream.discoverystream.endpoints pref to http,https
• Open the "about:home#devtools" page and observe the page.

Verified using the Firefox Nightly 80.0a1 (Build ID: 20200712214458) on Windows 10 x64, macOS 10.15, and Ubuntu Linux 18.04.