Closed
Bug 1651171
Opened 4 years ago
Closed 4 years ago
Convert NS_SUBTREE_DIRTY to an inline method of nsIFrame
Categories
(Core :: Layout, task)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla80
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(1 file)
NS_SUBTREE_DIRTY is a macro defined as follows.
#define NS_SUBTREE_DIRTY(_frame) \
(_frame)->HasAnyStateBits(NS_FRAME_IS_DIRTY | NS_FRAME_HAS_DIRTY_CHILDREN)
It really should be an nsIFrame's inline method live in nsIFrameInlines.h, for both the aesthetic reason and easy to call it from the debugger.
|
Assignee | |
Comment 1•4 years ago
|
||
I discover this while reviewing D78822 which skips some reflow for flex items. I'd like to clean this up after the patch lands.
|
|
Assignee | |
Comment 2•4 years ago
|
||
This is a straightforward conversion except that
NS_SUBTREE_DIRTY(this) can be written terser as IsSubtreeDirty().
|
||
Updated•4 years ago
|
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
|
|
||
Updated•4 years ago
|
Attachment #9162347 -
Attachment description: Bug 1651171 - Convert NS_SUBTREE_DIRTY to an nsIFrme's inline method. → Bug 1651171 - Convert NS_SUBTREE_DIRTY to an inline method of nsIFrame.
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cd8bddd0ab8f
Convert NS_SUBTREE_DIRTY to an inline method of nsIFrame. r=jfkthame
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in
before you can comment on or make changes to this bug.
Description
•