1651185 - about:studies is blank: Uncaught TypeError: can't access property "slice", study.userFacingName is undefined

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Chris Peterson [:cpeterson]]

My about:studies page is blank in my regular user profile (80 Nightly), but not in a clean user profile. yoasif reported seeing the same problem.

I see the following JavaScript error in the web console:

Uncaught TypeError: can't access property "slice", study.userFacingName is undefined
    render resource://normandy-content/about-studies/about-studies.js:282
    _renderValidatedComponentWithoutOwnerOrContext resource://normandy-vendor/ReactDOM.js:18
    _renderValidatedComponent resource://normandy-vendor/ReactDOM.js:18
    performInitialMount resource://normandy-vendor/ReactDOM.js:18
    mountComponent resource://normandy-vendor/ReactDOM.js:18
    mountComponent resource://normandy-vendor/ReactDOM.js:5
    mountChildren resource://normandy-vendor/ReactDOM.js:18
    _createInitialChildren resource://normandy-vendor/ReactDOM.js:18
    mountComponent resource://normandy-vendor/ReactDOM.js:18
    mountComponent resource://normandy-vendor/ReactDOM.js:5
    mountChildren resource://normandy-vendor/ReactDOM.js:18
    _createInitialChildren resource://normandy-vendor/ReactDOM.js:18
    mountComponent resource://normandy-vendor/ReactDOM.js:18
    mountComponent resource://normandy-vendor/ReactDOM.js:5
    performInitialMount resource://normandy-vendor/ReactDOM.js:18
    mountComponent resource://normandy-vendor/ReactDOM.js:18
    mountComponent resource://normandy-vendor/ReactDOM.js:5
    mountChildren resource://normandy-vendor/ReactDOM.js:18
    _createInitialChildren resource://normandy-vendor/ReactDOM.js:18
    mountComponent resource://normandy-vendor/ReactDOM.js:18
    mountComponent resource://normandy-vendor/ReactDOM.js:5
    _updateRenderedComponent resource://normandy-vendor/ReactDOM.js:18
    _performComponentUpdate resource://normandy-vendor/ReactDOM.js:18
    updateComponent resource://normandy-vendor/ReactDOM.js:18
    performUpdateIfNecessary resource://normandy-vendor/ReactDOM.js:18
    performUpdateIfNecessary resource://normandy-vendor/ReactDOM.js:5
    i resource://normandy-vendor/ReactDOM.js:5
    perform resource://normandy-vendor/ReactDOM.js:5
    perform resource://normandy-vendor/ReactDOM.js:5
    perform resource://normandy-vendor/ReactDOM.js:5
    v resource://normandy-vendor/ReactDOM.js:5
    closeAll resource://normandy-vendor/ReactDOM.js:5
    perform resource://normandy-vendor/ReactDOM.js:5
    batchedUpdates resource://normandy-vendor/ReactDOM.js:18
    d resource://normandy-vendor/ReactDOM.js:5
    o resource://normandy-vendor/ReactDOM.js:18
    enqueueSetState resource://normandy-vendor/ReactDOM.js:18
    setState resource://normandy-vendor/React.js:5
    handleEvent resource://normandy-content/about-studies/about-studies.js:66

I think this is a regression from bug 1624728.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1651185 - Fallback content for about:studies experiments without proper description

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/378336e0a2eb
Fallback content for about:studies experiments without proper description r=k88hudson

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/378336e0a2eb

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9162446 [details]
Bug 1651185 - Fallback content for about:studies experiments without proper description

Needed for bug 1624728. Approved for 79.0b7.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d2eaaa583f95

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (80.0a1 Build ID - 20200716212737) and the latest Firefox Beta (79.0b9 Build ID - 20200717001501) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15. Now, the enrolled studies are correctly displayed in the "about:studies" page.