Closed Bug 1651318 Opened 4 years ago Closed 4 years ago

Services.startup.startingUp is always true in XPCShell tests

Categories

(Toolkit :: Startup and Profile System, defect)

defect

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: darktrojan, Assigned: mossop)

References

Details

Attachments

(1 file)

In normal usage, startingUp becomes false with a call to DoneStartingUp() at final-ui-startup. XPCShell tests don't run this bit of code so it's always true, which was fine until bug 921157 came along and started printing deprecation warnings if the value was true. That's potentially also fine, but it did trip up one test and leaves a lot of (not necessarily accurate) log spew.

The severity field is not set for this bug.
:mossop, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dtownsend)
Severity: -- → S4
Flags: needinfo?(dtownsend)

This is actually quite annoying.

Assignee: nobody → dtownsend
Severity: S4 → S3

Since we don't go through the normal nsAppRunner startup process this just sends
the appropriate startup and shutdown signals to nsAppStartup at what look to be
roughly the right positions.

Pushed by dtownsend@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4f024c5faa9a XPCShell should inform nsIAppStartup when startup is complete and when shutdown begins. r=froydnj
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
See Also: → 1726813
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: