1651319 - Cleanup devtools calls to JSWindowActor sendAsyncMessage

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

We have two calls to JSWindowActor::sendAsyncMessage where we return this.sendAsyncMessage(...). However sendAsyncMessage doesn't return anything so this can be misleading as it feels like we might get a promise we can wait on (and we actually do that for one of them).

• https://searchfox.org/mozilla-central/rev/7ec7ee4a9bde171ba195ab46ed6077e4baaef34d/devtools/server/connectors/js-window-actor/DevToolsFrameParent.jsm#91
• https://searchfox.org/mozilla-central/rev/7ec7ee4a9bde171ba195ab46ed6077e4baaef34d/devtools/server/connectors/js-window-actor/DevToolsFrameParent.jsm#72

Plus the callsite where we wait on promises which don't exist:

• https://searchfox.org/mozilla-central/rev/7ec7ee4a9bde171ba195ab46ed6077e4baaef34d/devtools/server/actors/descriptors/watcher/target-helpers/frame-helper.js#67-73

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1651319 - Cleanup devtools calls to JSWindowActor sendAsyncMessage

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e90f3e158568
Cleanup devtools calls to JSWindowActor sendAsyncMessage r=ochameau

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e90f3e158568