Closed Bug 1651391 Opened 1 year ago Closed 9 months ago

Slightly tweak content process title

Categories

(DevTools :: Framework, enhancement, P3)

enhancement

Tracking

(Fission Milestone:M7, firefox87 fixed)

RESOLVED FIXED
87 Branch
Fission Milestone M7
Tracking Status
firefox87 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 2 open bugs)

Details

(Whiteboard: dt-fission-m3-mvp)

Attachments

(1 file)

For now, the content process target title in DevTools is Content Process [pid ${pid}],
but there is some different convention on how to label content processes.
about:processes uses ${pid} ${origin} ${remoteType}
about:memory uses ${remoteType} (pid ${pid})
profiler uses ${remoteType} PID: ${pid}
I don't know if there is some other?

What is clear is that we would benefit from showing the remote type and it may be useful to also display the origin, when available.

The title is implemented over here:
https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/devtools/client/fronts/targets/content-process.js#32-34
FYI, processID is surprisingly set from here:
https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/devtools/client/fronts/descriptors/process.js#53
(It should probably be passed from the form instead of the descriptor!)
Speaking about the form, this is where you would have to add new attributes if you want to pass some additional data, like the process origin:
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/content-process.js#141-150
And such additional data would most likely come from Services.appinfo, which exposes:
https://searchfox.org/mozilla-central/source/xpcom/system/nsIXULRuntime.idl#94-115

Fission Milestone: --- → M6c

Alex, there's a patch here but no reviewers. Could you please finalize this to close the bug?
Also, there is no dt-xx whiteboard tag for this, do we need one for dt-m2 or dt-m3?

Flags: needinfo?(poirot.alex)

Honza, this DevTools Fission bug has a patch, but no reviewers. I can't tell from comment 1 whether this fix landed in a different bug. Should this bug block shipping Fission? It blocks dt-fission-execution-context meta bug 1605153, but doesn't have a dt-fission whiteboard tag.

Fission Milestone: M6c → M7
Flags: needinfo?(odvarko)
Severity: -- → S3
Flags: needinfo?(odvarko)
Priority: -- → P3
Whiteboard: dt-fission-m3-mvp
Whiteboard: dt-fission-m3-mvp → dt-fission-m3-reserve
Flags: needinfo?(poirot.alex)
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Whiteboard: dt-fission-m3-reserve → dt-fission-m3-mvp
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/053436fec044
Display remote type in the browser toolbox context selector. r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.