1651402 - Switch devtools to use Debugger.Object.isError instead of .class

Status: RESOLVED FIXED

(DevTools :: Console, task)

Description

[Tom S [:evilpie]]

We want to change the JSClass name for error objects to be more specific. So instead of just "Error" we would use "TypeError" etc. This seems to break devtools, which just checks for .class == "Error" in some cases.

I made a try push that should show these failures. What you would probably need to do is replace code like this with result?.isError. (I am not 100% sure if result is actually a Debugger.Object, but get the idea)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Thanks for filing this Tom.
I'll pull your patch and investigate the different failures it causes

Comment 2

[Tom S [:evilpie]]

Attachment: Bug 1651402 - Change Error JSClass names

Comment 3

[Tom S [:evilpie]]

This patch has all the required work on the SpiderMonkey side.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1651402 - Use obj.isError instead of obj.class='Error' in DevTools code. r=davidwalsh

Depends on D82876

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90d1f5107d9f
Change Error JSClass names r=anba
https://hg.mozilla.org/integration/autoland/rev/6ac9edc64fe5
Use obj.isError instead of obj.class='Error' in DevTools code. r=davidwalsh

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/90d1f5107d9f
https://hg.mozilla.org/mozilla-central/rev/6ac9edc64fe5