Open Bug 1651432 Opened 5 years ago Updated 3 years ago

Perfherder UI tests need to be updated

Categories

(Tree Management :: Perfherder, task, P2)

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: sclements, Assigned: bacasandrei)

Details

(Keywords: good-first-bug)

There's a deprecation notice for at least one test that uses waitForElement for graphs_view_test: "waitForElementhas been deprecated. Use afind*query (preferred: https://testing-library.com/docs/dom-testing-library/api-queries#findby) or usewaitFor` instead: https://testing-library.com/docs/dom-testing-library/api-async#waitfor"

There's also been a lot of react console warnings for this particular test suite that have been occurring for a while and creates a lot of noise when running the tests. It'd be nice to get those cleaned up.

Assignee: nobody → beatrice.acasandrei
Severity: -- → S4
Status: NEW → ASSIGNED
Priority: -- → P1

How can I view these console warnings? I have tried to run the tests locally but there is no such warning. Thanks in advance for your help!

Flags: needinfo?(sclements)

I don't see that particular waitForElement warning anymore. Perhaps someone fixed it... I do see a few different console.error messages for Perfherder components though.

Flags: needinfo?(sclements)

There's also a really annoying alerts tests (in alerts_test file) that fails intermittently when running yarn test (outside of docker) locally but it never fails on staging/production. It would be wonderful if that could be fixed :)

Are you running the tests in docker or outside of docker and not seeing any of the red console.error warnings?

(In reply to Sarah Clements [:sclements] from comment #4)

Are you running the tests in docker or outside of docker and not seeing any of the red console.error warnings?

I am running the tests outside of docker and I am also getting all the errors and warnings mentioned by you. I just couldn't find the waitForElement warning and didn't know how to reproduce it.

Priority: P1 → P2
Keywords: good-first-bug
You need to log in before you can comment on or make changes to this bug.