1651463 - Firefox with client-side decorations restores its previous position incorrectly

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Vlad Zahorodnii [:zzag]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

In order to reproduce this bug, you need to run kwin as the window manager, I'm not sure whether this issue can be seen with other window managers, e.g. Mutter.

• Use X11
• Check "Restore previous session" in about:preferences
• Close and open Firefox several times in a row

Actual results:

Every time step 3 is repeated, Firefox gets slightly shifted.

Firefox sends a ConfigureRequest to the window manager to restore its previous position. However, the position specified in the ConfigureRequest doesn't correspond to the last window position, it's actually "last window position - csd borders".

It seems like switching to gdk_window_move() in NativeMove() and NativeMoveResize() fixes the problem.

Expected results:

Firefox is placed at its previous location.

Comment 1

[Vlad Zahorodnii [:zzag]]

• It seems like switching to gdk_window_move() in NativeMove() and NativeMoveResize() fixes the problem.

• It seems like switching from gtk_window_move() to gdk_window_move() in NativeMove() and NativeMoveResize() fixes the problem.

Comment 2

[B.J. Herbison]

Does it initially appear in the wrong position, or does it appear in the correct position and jump a few seconds later?

The behavior with a jump using XFCE is bug 1471094.

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Confirming.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Putting bug 1812289 as the regressor because CSD is now the default on kwin too.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1812289

:emilio, since you are the author of the regressor, bug 1812289, could you take a look?

For more information, please visit BugBot documentation.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1651463 - Add CSD offset in MoveResize as needed. r=stransky

gtk_window_move undoes that...

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb8fcd48aeb3
Add CSD offset in MoveResize as needed. r=stransky

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/fb8fcd48aeb3

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.Also, don't forget to request an uplift for the patches in the regression caused by this fix.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.