Closed
Bug 165162
Opened 24 years ago
Closed 24 years ago
From page source view CTRL-E and File menu-Edit Page do not act the same.
Categories
(SeaMonkey :: Composer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.2alpha
People
(Reporter: dehags, Assigned: cmanske)
Details
Attachments
(1 file)
|
986 bytes,
patch
|
Brade
:
review+
hewitt
:
superreview+
|
Details | Diff | Splinter Review |
Using CTRL-E from Mozilla to open Composer works as expected, loading Composer
and showing the page in "Normal" mode.
Using CTRL-U from Mozilla to view the source works as expected.
Now here is where it gets strange.
From the source code view:
If I press CTRL-E it opens Composer with the syntax highlighted HTML showing in
the "Normal" mode window.
On the other hand if I open the File menu and select Edit Page then it opens
Composer showing the page just as if I had opened it from Mozilla using CTRL-E.
-----
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.1) Gecko/20020826
| Assignee | ||
Comment 2•24 years ago
|
||
When the menu command is used, the method ViewSourceEditPage() is called, which
strips off "view-source:" from the URL. When the accelerator key is used, the
command triggered is "Browser:EditPage()" because of the navigatory overlay.
This calls directly into editPageOrFrame().
The best fix is to always strip "view-source:" in Composer's 'editPage()'.
| Assignee | ||
Updated•24 years ago
|
Comment 3•24 years ago
|
||
so... what if someone loads a view-source: url in browser and then does "Edit
Page" on it? Would they really expect to have the view-source: stripped??
| Assignee | ||
Comment 4•24 years ago
|
||
Boris: Yes, I thought of that and unfortunately, I don't think we have any other
choice. We would end up editing the HTML, not the source they see in the browser.
We're really not a very good text editor anyway, so hopefully people
don't expect to edit HTML source like that!
Comment 5•24 years ago
|
||
Comment on attachment 97104 [details] [diff] [review]
patch v2
r=brade but please fix comment to be "view-source:"
Attachment #97104 -
Flags: review+
| Assignee | ||
Comment 6•24 years ago
|
||
Note: comment changed to:
// Always strip off "view-source:"
Whiteboard: [FIX IN HAND] need r=,sr= → [FIX IN HAND] need sr=
Comment 7•24 years ago
|
||
Comment on attachment 97104 [details] [diff] [review]
patch v2
sr=hewitt
Attachment #97104 -
Flags: superreview+
| Assignee | ||
Comment 8•24 years ago
|
||
checked into 1.2 trunk
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•