Closed Bug 165162 Opened 24 years ago Closed 24 years ago

From page source view CTRL-E and File menu-Edit Page do not act the same.

Categories

(SeaMonkey :: Composer, defect)

x86
Windows 98
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.2alpha

People

(Reporter: dehags, Assigned: cmanske)

Details

Attachments

(1 file)

Using CTRL-E from Mozilla to open Composer works as expected, loading Composer and showing the page in "Normal" mode. Using CTRL-U from Mozilla to view the source works as expected. Now here is where it gets strange. From the source code view: If I press CTRL-E it opens Composer with the syntax highlighted HTML showing in the "Normal" mode window. On the other hand if I open the File menu and select Edit Page then it opens Composer showing the page just as if I had opened it from Mozilla using CTRL-E. ----- Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.1) Gecko/20020826
-->cmanske
Assignee: syd → cmanske
Keywords: nsbeta1
Attached patch patch v2 — — Splinter Review
When the menu command is used, the method ViewSourceEditPage() is called, which strips off "view-source:" from the URL. When the accelerator key is used, the command triggered is "Browser:EditPage()" because of the navigatory overlay. This calls directly into editPageOrFrame(). The best fix is to always strip "view-source:" in Composer's 'editPage()'.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: patch, review
Whiteboard: [FIX IN HAND] need r=,sr=
Target Milestone: --- → mozilla1.2alpha
so... what if someone loads a view-source: url in browser and then does "Edit Page" on it? Would they really expect to have the view-source: stripped??
Boris: Yes, I thought of that and unfortunately, I don't think we have any other choice. We would end up editing the HTML, not the source they see in the browser. We're really not a very good text editor anyway, so hopefully people don't expect to edit HTML source like that!
Comment on attachment 97104 [details] [diff] [review] patch v2 r=brade but please fix comment to be "view-source:"
Attachment #97104 - Flags: review+
Note: comment changed to: // Always strip off "view-source:"
Whiteboard: [FIX IN HAND] need r=,sr= → [FIX IN HAND] need sr=
Comment on attachment 97104 [details] [diff] [review] patch v2 sr=hewitt
Attachment #97104 - Flags: superreview+
checked into 1.2 trunk
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Keywords: patch, review
Resolution: --- → FIXED
Whiteboard: [FIX IN HAND] need sr=
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: