1651641 - servo/components/style/build.rs references PYTHON3 environment variable which is not necessarily set

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[l.majewski]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Build firefox 68esr with meta-browser layer in Yocto thud

Actual results:

Error as described in this issue:
https://github.com/OSSystems/meta-browser/issues/338

Expected results:

Firefox shall build without any workarounds needed

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Ricky Stewart]

The actual code in question has changed (it now references Python 3), but the underlying problem remains the same, that a typical build of Firefox doesn't plumb the configured python down to the Cargo build, where this environment variable is read.

Comment 3

[Ricky Stewart]

Attachment: Bug 1651641 - `servo/components/style/build.rs` reads `PYTHON3` configuration value in addition to environment variable

The previous logic would check the value of the PYTHON3 environment variable, which is not set by the Firefox build system, so this build script tends to just use the python3 at the tip of the PATH, regardless of which value you've configured for it. Instead, it should prefer to read from the OBJDIR if one is present.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbfe3335cfe5
`servo/components/style/build.rs` reads `PYTHON3` configuration value in addition to environment variable r=glandium

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cbfe3335cfe5