Closed Bug 1651648 Opened 4 years ago Closed 4 years ago

Unify locator strategies for chrome and content

Categories

(Remote Protocol :: Marionette, task, P3)

task

Tracking

(firefox80 fixed)

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: whimboo, Assigned: impossibus)

References

Details

(Whiteboard: [marionette-fission-mvp])

Attachments

(1 file)

Currently chrome scope only allows a subset of the allowed locator strategies:

https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/testing/marionette/driver.js#96-102
https://searchfox.org/mozilla-central/source/testing/marionette/listener.js#89-98

What's basically missing are the following:

  element.Strategy.Name,
  element.Strategy.LinkText,
  element.Strategy.PartialLinkText,

Given that XUL is gone and we now have XHTML for chrome windows, we should no longer block these strategies.

By doing that the checks if the given strategy is valid only need to be done in driver.js, and can be removed from listener.js.

Maja, would you be interested to work on that bug?

Assignee: nobody → mjzffr
Status: NEW → ASSIGNED
Pushed by mjzffr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f4a2f7b515ae
Unify locator strategies for chrome and content r=marionette-reviewers,whimboo
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Whiteboard: [marionette-fission-mvp]
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: