1651649 - Use toggle button for switching between raw and formatted response view

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: image.png

Switching between "raw text" and "formated" (e.g. JSON) should be done using a Toggle button. The same we are using for switching between raw and formatted headers.
(we can also use the same label "Raw")

See the attached screenshot

Honza

Comment 2

[Sebastian Zartner [:sebo]]

Attachment: Bug 1651649 - Use toggle button for switching between raw and formatted response view. r=bomsy,honza

This is a WIP patch. It replaces the accordion widget by a simple headline with a toggle button at the end.

Open points are:

• Raw view is currently default, even when there's a formatted view. How to change that?
• Headline name is now always "Response Payload". Is that ok or should it change to "JSON", "HTML", and other types accordingly?
• Formatting isn't perfect yet (especially regarding the size of the source container)
• Tests need to be created/updated

Honza, can you help me here?

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I like that patch!

(In reply to Sebastian Zartner [:sebo] from comment #2)

• Raw view is currently default, even when there's a formatted view. How to change that?

@Bomsy can you help here, please?

• Headline name is now always "Response Payload". Is that ok or should it change to "JSON", "HTML", and other types accordingly?

I agree with the later, the headline name should change dynamically according to the state of the toggle and displayed content

• Formatting isn't perfect yet (especially regarding the size of the source container)

Yep, I noticed that the scrollbar is broken for raw view and the vertical one too long for the JSON view.

Honza

Comment 4

[Hubert Boma Manilla (:bomsy)]

I've added comments in Phabricator.

Comment 5

[Sebastian Zartner [:sebo]]

Just a quick update: I already fixed all the points you mentioned in Phabricator and here and also added the switch to the WebSocket data display as that's also part of the response view.

I am still working on updating all the tests that cover the response view. I'll try to finish up the patch the next few days.

Sebastian

Comment 6

[Hubert Boma Manilla (:bomsy)]

That's great sebo! Thanks for the update.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58fcc8f7377a
Use toggle button for switching between raw and formatted response view. r=Honza,bomsy

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/58fcc8f7377a