Support shell options natively in test262-update.py
Categories
(Core :: JavaScript Engine, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: mgaudet, Assigned: anba)
Details
Attachments
(5 files)
When developing a new language feature, it's nice to guard it by a shell option at the beginning.
test262-update.py supports injecting feature detection code, but sometimes writing said feature detection code is not particularly pleasant, and it would be nicer to just have shell-option(x) instead.
Unknowns:
- Can we support multiple shell options? (ie, does something like
shell-option(--enable-foo;--enable-bar)work? - Our test262 test run in the shell and the browser; but shell options are obviously only for the shell: So a feature should then imply skip-if browser?
|
Assignee | |
Comment 1•4 years ago
|
||
Remove "AggregateError" from the list of conditionally available features and
then reimport test262.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
Also change the update script to no longer generate an external reftest entry
when shell-options are needed, now that shell-options can be defined in an
inline reftest entry.
Depends on D83821
|
|
Assignee | |
Comment 3•4 years ago
|
||
Also move the proxy private-fields exclusions into standard block of skipped
tests due to SpiderMonkey issues.
Depends on D83833
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D83834
|
|
Assignee | |
Comment 5•4 years ago
|
||
Depends on D83835
|
|
Assignee | |
Comment 6•4 years ago
|
||
(In reply to Matthew Gaudet (he/him) [:mgaudet] from comment #0)
Unknowns:
- Can we support multiple shell options? (ie, does something like
shell-option(--enable-foo;--enable-bar)work?
shell-option(--enable-foo) shell-option(--enable-bar) already works.
- Our test262 test run in the shell and the browser; but shell options are obviously only for the shell: So a feature should then imply skip-if browser?
Yes, we should skip tests in the browser when the feature is only available through shell-options.
Pushed by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/469781e39781 Part 1: AggregateError is no longer only conditionally present. r=mgaudet https://hg.mozilla.org/integration/autoland/rev/9ed77e348f11 Part 2: Automatically generate shell-options flags for private-field features. r=mgaudet https://hg.mozilla.org/integration/autoland/rev/f4d576e2778a Part 3: Remove no longer needed explicit reftest entry for private-fields. r=mgaudet https://hg.mozilla.org/integration/autoland/rev/2d0189a24a33 Part 4: Update test262 July 2020. r=mgaudet https://hg.mozilla.org/integration/autoland/rev/72aacf8736aa Part 5: Update test262 exclusion list. r=mgaudet
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/469781e39781
https://hg.mozilla.org/mozilla-central/rev/9ed77e348f11
https://hg.mozilla.org/mozilla-central/rev/f4d576e2778a
https://hg.mozilla.org/mozilla-central/rev/2d0189a24a33
https://hg.mozilla.org/mozilla-central/rev/72aacf8736aa
Description
•