Simplify implementation of WebDriver:SwitchToFrame
Categories
(Remote Protocol :: Marionette, task, P1)
Tracking
(firefox80 fixed)
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [marionette-fission-mvp])
Attachments
(5 files)
The WebDriver:SwitchToFrame is kinda complicated for both chrome and content. Most of the code for chrome might not be needed because it was used for B2G and is outdated. Others like in listener.js could definitely be improved.
Without it I can see problems in getting it working via the JSWindowActor implementation.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
The WebDriver spec doesn't allow using a name for the frame to switch to.
Also it's only used in Marionette unit tests for chrome scope
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D83082
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D83083
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D83084
|
|
Assignee | |
Comment 5•4 years ago
|
||
Depends on D83085
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3a59ca8ecc0c [marionette] Remove support for frame name in WebDriver:SwitchToFrame. r=marionette-reviewers,maja_zf https://hg.mozilla.org/integration/autoland/rev/19a57301ca73 [marionette] Use PollPromise instead of timer for WebDriver:SwitchToFrame. r=marionette-reviewers,maja_zf https://hg.mozilla.org/integration/autoland/rev/51ffeb21b276 [marionette] Simplify WebDriver:SwitchToFrame code in driver.js. r=marionette-reviewers,maja_zf https://hg.mozilla.org/integration/autoland/rev/291605080626 [marionette] Simplify WebDriver:SwitchToFrame code in listener.js. r=marionette-reviewers,maja_zf https://hg.mozilla.org/integration/autoland/rev/a0dfdc6b4d69 [wdspec] Move Marionette unit tests for Switch to Frame to Wdspec. r=marionette-reviewers,maja_zf
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24598 for changes under testing/web-platform/tests
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3a59ca8ecc0c
https://hg.mozilla.org/mozilla-central/rev/19a57301ca73
https://hg.mozilla.org/mozilla-central/rev/51ffeb21b276
https://hg.mozilla.org/mozilla-central/rev/291605080626
https://hg.mozilla.org/mozilla-central/rev/a0dfdc6b4d69
Upstream PR merged by moz-wptsync-bot
|
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•1 year ago
|
Description
•