Closed Bug 1651698 Opened 2 months ago Closed 2 months ago

Display about:webrtc remote and local SDP history in columns

Categories

(Core :: WebRTC, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The SDP history feature added in Bug 1624967 is very helpful, but you have to scroll up and down the page to compare local and remote sdp. Displaying them in columns would make comparison easier.

Attached image Proposed UI

Let the bikeshedding commence :)

This may be hard to pull off and retain the history ordering information over the local and remote side. As it stands today (one column) you get a total ordering of the SDP history, so one can easily trace the flow, at the cost of making textual comparisons harder. The proposal would make comparisons easier, at the expense of ordering. Perhaps we could add a table above with the ordering, with links that would scroll the two columns to the selected SDPs?

(In reply to Nico Grunbaum [:ng, @chew:mozilla.org] from comment #3)

This may be hard to pull off and retain the history ordering information over the local and remote side. As it stands today (one column) you get a total ordering of the SDP history, so one can easily trace the flow, at the cost of making textual comparisons harder. The proposal would make comparisons easier, at the expense of ordering. Perhaps we could add a table above with the ordering, with links that would scroll the two columns to the selected SDPs?

I did include the relative timestamps so that you don't lose the ordering completely, but I agree that it does make it more difficult to trace the history. I'll have a look and see if I can get the ordering information and links working like you suggest. I had thought about that initially a bit and wasn't sure it was worth the extra effort because my primary use case is comparing SDPs, but if it is important to you, I'm sure it will be important to others as well.

If that is too hard, perhaps just add a bold/large sequence number to each item in the history? I don't think that big changes needs to block this, if you want to do something more complicated like I originally suggested, and it could be done in a follow up.

I've added a list of sdp events to the top that you can click to scroll the associated sdp into view.

Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58bf8fbdf8a9
Display local and remote sdp history in columns on about:webrtc; r=ng
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.