Closed Bug 1651699 Opened 3 months ago Closed 3 months ago

Enable dav1d assembly builds in Android

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: achronop, Assigned: achronop)

References

Details

Attachments

(2 files)

Android is the only platform left that assembly files of dav1d are not built.

Blocks: 1644566

https://treeherder.mozilla.org/#/jobs?repo=try&revision=80b1cd7efc54d7401d1735bce008c4f33013625e

All Android flavors build fine besides x86 (4.2) which has a nasty error in gold-linker.

Copy here the error Android 4.2 x86 :

[task 2020-07-09T13:25:33.537Z] 13:25:33     INFO -  /builds/worker/fetches/android-ndk/toolchains/x86-4.9/prebuilt/linux-x86_64/lib/gcc/i686-linux-android/4.9.x/../../../../i686-linux-android/bin/ld: internal error in relocate_section, at /buildbot/src/android/binutils/toolchain/binutils/binutils-2.27/gold/i386.cc:3683
[task 2020-07-09T13:25:33.537Z] 13:25:33     INFO -  clang-9: error: linker command failed with exit code 1 (use -v to see invocation)

Also, I tested the AArch64 binary in my phone and works well.

When libdav1d assembly builds are enabled gold produces an internal error.

Nathan suggested a way to replace gold with ld which is green on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9232549f36c291e42ae2ed187c5878e4de30926

Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3fb2cf087d90
Use ld instead of gold in Android x86. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/17fc1829f9f8
Enable dav1d assembly builds on Android. r=TD-Linux
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.