1651699 - Enable dav1d assembly builds in Android

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Alex Chronopoulos [:achronop]]

Android is the only platform left that assembly files of dav1d are not built.

Comment 1

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=80b1cd7efc54d7401d1735bce008c4f33013625e

All Android flavors build fine besides x86 (4.2) which has a nasty error in gold-linker.

Copy here the error Android 4.2 x86 :

[task 2020-07-09T13:25:33.537Z] 13:25:33     INFO -  /builds/worker/fetches/android-ndk/toolchains/x86-4.9/prebuilt/linux-x86_64/lib/gcc/i686-linux-android/4.9.x/../../../../i686-linux-android/bin/ld: internal error in relocate_section, at /buildbot/src/android/binutils/toolchain/binutils/binutils-2.27/gold/i386.cc:3683
[task 2020-07-09T13:25:33.537Z] 13:25:33     INFO -  clang-9: error: linker command failed with exit code 1 (use -v to see invocation)

Also, I tested the AArch64 binary in my phone and works well.

Comment 2

[Alex Chronopoulos [:achronop]]

A green try with Android x86 excluded from assembly builds:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1399dc64cf5c4284cbddae4ad30758c0916cd6fd

Comment 3

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1651699 - Use ld instead of gold in Android x86. r?froydnj

When libdav1d assembly builds are enabled gold produces an internal error.

Comment 4

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1651699 - Enable dav1d assembly builds on Android. r?TD-Linux

Depends on D83522

Comment 5

[Alex Chronopoulos [:achronop]]

Nathan suggested a way to replace gold with ld which is green on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9232549f36c291e42ae2ed187c5878e4de30926

Comment 6

[Alex Chronopoulos [:achronop]]

Full run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b026ac368ed83c372a7c52dab3895afabe4d171

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fb2cf087d90
Use ld instead of gold in Android x86. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/17fc1829f9f8
Enable dav1d assembly builds on Android. r=TD-Linux

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/3fb2cf087d90
https://hg.mozilla.org/mozilla-central/rev/17fc1829f9f8