Closed Bug 1651709 Opened 5 years ago Closed 5 years ago

Miscellaneous bugfixes in disabled ParserAtom code

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: djvj, Assigned: djvj)

References

Details

Attachments

(1 file)

This bug is to sort out some back-filled bugfix work that came out of the main "hairball" ParserAtoms patch. The bug is a post-hoc creation of the patch, which:

  1. Fixes a bug in the isIndex() implementation of ParserAtomEntry.
  2. Adds proto-names to the parser-atoms commonNames table.
  3. Removes the whole "Invalid" construction scheme for ParserAtomIds, and just allows them to be constructed with nullptr entries.

The current patch up for review doesn't compile without this patch.

Assignee: nobody → kvijayan
Status: NEW → ASSIGNED
Severity: -- → N/A
Priority: -- → P1
Pushed by kvijayan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bf57564c564e Miscellaneous bugfixes in disabled ParserAtom code. r=tcampbell
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: