1651714 - Reduce includes of TabMessageUtils.h

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task)

Description

[Simon Giesecke [:sg] [he/him]]

TabMessageUtils.h is expensive to include. According to a ClangBuildAnalyer measurement, it is the 2nd most expensive header and included 317 times (on Linux):

*** Expensive headers:
532744 ms: /home/simon/work/fuzzy/obj-x86_64-pc-linux-gnu-optimized/ipc/ipdl/_ipdlheaders/mozilla/dom/DOMTypes.h (included 306 times, avg 1740 ms), included via:
  ClearSiteData.cpp HttpBaseChannel.h  (4272 ms)
  RemoteDecoderModule.o ContentChild.h BrowserBridgeChild.h PBrowserBridgeChild.h PBrowserBridge.h  (3516 ms)
  FOGIPC.cpp ContentChild.h BrowserBridgeChild.h PBrowserBridgeChild.h PBrowserBridge.h  (3394 ms)
  ActorsParent.cpp PBackgroundParent.h PBackground.h  (3376 ms)
  ChildSHistory.cpp ContentChild.h BrowserBridgeChild.h PBrowserBridgeChild.h PBrowserBridge.h  (3361 ms)
  FileChannelChild.cpp ContentChild.h BrowserBridgeChild.h PBrowserBridgeChild.h PBrowserBridge.h  (3341 ms)
  ...
 
461832 ms: /home/simon/work/fuzzy/obj-x86_64-pc-linux-gnu-optimized/dist/include/mozilla/dom/TabMessageUtils.h (included 317 times, avg 1456 ms), included via:
  PProcessHangMonitor.cpp  (5059 ms)
  PGMPTimer.cpp PGMPParent.h  (3436 ms)
  RDDProcessImpl.o RDDProcessImpl.h RDDParent.h PRDDParent.h  (3216 ms)
  RDDProcessHost.o RDDChild.h PRDDChild.h  (3127 ms)
  RDDChild.o RDDChild.h PRDDChild.h  (3066 ms)
  RDDParent.o RDDParent.h PRDDParent.h  (3018 ms)
  ...

Actually, at most places only the type defintions are needed, not the IPDLParamTraits along with their dependencies.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1651714 - Reduce expensive includes for TabMessageUtils.h. r=smaug

With these changes, on my Linux analysis with ClangBuildAnalyzer, the
top two expensive headers, DOMTypes.h and TabMessageUtils.h are no longer
among the 30 most expensive headers.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b30958982514
Reduce expensive includes for TabMessageUtils.h. r=smaug

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/b30958982514