Closed Bug 1651723 Opened 5 years ago Closed 5 years ago

Investigate storing atom pinned state in the atoms table only

Categories

(Core :: JavaScript Engine, defect, P2)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

Bug 1651723 - Store atom pinned state in the atoms table only r?jandem
47 bytes, text/x-phabricator-request
Details | Review

As Jan commented in bug 1629128 comment 15, it would be better not to store the 'atom is pinned' state in two places. Currently this is causing a data race (which will be fixed by stencil) but also it would be better to not modify the string flags after initialisation.

Looking back it seems I was responsible for this situation in bug 1445196. I tried to remove the duplication in bug 1547565 by using only the string flags, but this regressed marking performance.

Severity: -- → S4
Type: task → defect
Priority: -- → P2
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a2631e9fb4d1 Store atom pinned state in the atoms table only r=jandem

Backed out changeset a2631e9fb4d1 (bug 1651723) for atom related bustage

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=FA7XdyXDQxiMbhAq9U0k8Q.0&searchStr=build&fromchange=7341f7757a0b1cb231387e896adf82faf088f1d0&tochange=64d26ee7d9e7eb729b73b4564bbfff6b3f0d66d1

Backout link: https://hg.mozilla.org/integration/autoland/rev/64d26ee7d9e7eb729b73b4564bbfff6b3f0d66d1

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309347794&repo=autoland&lineNumber=65681

[task 2020-07-10T17:15:10.212Z] 17:15:10     INFO -  package> make[4]: Entering directory '/builds/worker/workspace/obj-build/browser/installer'
[task 2020-07-10T17:15:10.212Z] 17:15:10     INFO -  package> cp ../../mozinfo.json ../../dist//target.mozinfo.json
[task 2020-07-10T17:15:10.212Z] 17:15:10     INFO -  package> /builds/worker/workspace/obj-build/_virtualenvs/init_py3/bin/python /builds/worker/checkouts/gecko/toolkit/mozapps/installer/informulate.py \
[task 2020-07-10T17:15:10.212Z] 17:15:10     INFO -  package> 	../../dist//target.json ../../dist//buildhub.json ../../dist//target_info.txt \
[task 2020-07-10T17:15:10.212Z] 17:15:10     INFO -  package> 	linux-x86_64 \
[task 2020-07-10T17:15:10.212Z] 17:15:10     INFO -  package> 	 --package=../../dist/target.tar.bz2 --installer=
[task 2020-07-10T17:15:10.213Z] 17:15:10     INFO -  package> # Generate a file that describes the local Normandy client.
[task 2020-07-10T17:15:10.213Z] 17:15:10     INFO -  package> env LD_LIBRARY_PATH="/builds/worker/workspace/obj-build/dist/bin:/builds/worker/fetches/clang/lib:/builds/worker/fetches/clang/lib32:../../dist//bin" \
[task 2020-07-10T17:15:10.213Z] 17:15:10     INFO -  package> 	../../dist//bin/xpcshell \
[task 2020-07-10T17:15:10.213Z] 17:15:10     INFO -  package> 	/builds/worker/checkouts/gecko/toolkit/components/normandy/metadata-script.js ../../dist//target.normandy.json
[task 2020-07-10T17:15:10.213Z] 17:15:10     INFO -  package>
[task 2020-07-10T17:15:10.214Z] 17:15:10     INFO -  package> ** (xpcshell:11903): WARNING **: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files
[task 2020-07-10T17:15:10.214Z] 17:15:10     INFO -  package> Hit MOZ_CRASH(*** Atom not marked for zone 0x7ff8126f1000 at argument 1) at /builds/worker/checkouts/gecko/js/src/vm/JSContext-inl.h:109
[task 2020-07-10T17:15:10.214Z] 17:15:10     INFO -  package> Segmentation fault
[task 2020-07-10T17:15:10.214Z] 17:15:10     INFO -  package> /builds/worker/checkouts/gecko/toolkit/mozapps/installer/packager.mk:111: recipe for target 'make-package' failed
[task 2020-07-10T17:15:10.214Z] 17:15:10    ERROR -  package> make[4]: *** [make-package] Error 139
[task 2020-07-10T17:15:10.214Z] 17:15:10     INFO -  package> make[4]: Leaving directory '/builds/worker/workspace/obj-build/browser/installer'
[task 2020-07-10T17:15:10.215Z] 17:15:10     INFO -  package> /builds/worker/checkouts/gecko/config/rules.mk:390: recipe for target 'default' failed
[task 2020-07-10T17:15:10.215Z] 17:15:10    ERROR -  package> make[3]: *** [default] Error 2
[task 2020-07-10T17:15:10.215Z] 17:15:10     INFO -  package> /builds/worker/checkouts/gecko/browser/build.mk:6: recipe for target 'package' failed
[task 2020-07-10T17:15:10.215Z] 17:15:10    ERROR -  package> make[2]: *** [package] Error 2
[task 2020-07-10T17:15:10.219Z] 17:15:10     INFO -  /builds/worker/checkouts/gecko/build/moz-automation.mk:110: recipe for target 'automation/package' failed
[task 2020-07-10T17:15:10.220Z] 17:15:10    ERROR -  make[1]: *** [automation/package] Error 2
[task 2020-07-10T17:15:10.220Z] 17:15:10     INFO -  make[1]: *** Waiting for unfinished jobs....
Flags: needinfo?(jcoppeard)
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/965d8227390a Store atom pinned state in the atoms table only r=jandem

https://hg.mozilla.org/mozilla-central/rev/965d8227390a

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Flags: needinfo?(jcoppeard)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: