Open Bug 1651728 Opened 2 years ago Updated 4 months ago

Reader mode toolbar is saved with the document

Categories

(Toolkit :: Reader Mode, defect, P3)

78 Branch
defect

Tracking

()

People

(Reporter: panos.stokas, Unassigned)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Whiteboard: [about-reader-ui])

Attachments

(1 file, 2 obsolete files)

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Saved an html page while in Reader mode

Actual results:

The Reader mode toolbar was saved with the page

Expected results:

Only the Reader-mode-formatted page should have been saved. The toolbar is not part of the document, it's part of the user interface.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Reader Mode
Product: Firefox → Toolkit
Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
See Also: → 1426775
Whiteboard: [about-reader-ui]
Assignee: nobody → burnha42
Status: NEW → ASSIGNED
Attachment #9260305 - Attachment is obsolete: true
Attachment #9260307 - Attachment description: Bug 1651728 Remove reader mode toolbar from saved document. r=niklas,mtigley → WIP: Bug 1651728 Remove reader mode toolbar from saved document. r=niklas,mtigley
Attachment #9260307 - Attachment description: WIP: Bug 1651728 Remove reader mode toolbar from saved document. r=niklas,mtigley → Bug 1651728 Remove reader mode toolbar from saved document. r=niklas,mtigley
Attachment #9260307 - Attachment description: Bug 1651728 Remove reader mode toolbar from saved document. r=niklas,mtigley → WIP: Bug 1651728 Remove reader mode toolbar from saved document. r=niklas,mtigley
Attachment #9263527 - Attachment description: WIP: Bug 1651728 Remove reader mode toolbar from saved document. r=niklas,mtigley → Bug 1651728 Remove reader mode toolbar from saved document. r=niklas,mtigley
Attachment #9260307 - Attachment is obsolete: true
Attachment #9263527 - Attachment description: Bug 1651728 Remove reader mode toolbar from saved document. r=niklas,mtigley → WIP: Bug 1651728 Remove reader mode toolbar from saved document. r=niklas,mtigley
Attachment #9263527 - Attachment description: WIP: Bug 1651728 Remove reader mode toolbar from saved document. r=niklas,mtigley → Bug 1651728 Remove reader mode toolbar from saved document. r=niklas,mtigley
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49df084db953
Remove reader mode toolbar from saved document. r=niklas,mtigley
Regressions: 1760866

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:burnha42, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(nbaumgardner)
Flags: needinfo?(burnha42)
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0aae935c87e2
Remove reader mode toolbar from saved document. r=niklas,mtigley
Regressions: 1764182
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch

Backed out for causing Bug 1764182

Backout link

Push with failures

Failure log

Failure line(s): TEST-UNEXPECTED-FAIL | toolkit/components/reader/test/browser_readerMode_download.js | A promise chain failed to handle a rejection: JSWindowActorParent.sendQuery: JSWindowActorParent cannot send at the moment - stack: aboutReaderCb@resource://gre/modules/DownloadLegacy.jsm:438:19

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 101 Branch → ---

Backout has been merged to central

Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41bd981c3622
Remove reader mode toolbar from saved document. r=niklas,mtigley

Backed out for causing bc failures on browser_readerMode_download.js

Backout link

Push with failures

Failure log

Failure line(s): TEST-UNEXPECTED-FAIL | toolkit/components/reader/test/browser_readerMode_download.js | A promise chain failed to handle a rejection: JSWindowActorParent.sendQuery: JSWindowActorParent cannot send at the moment - stack: aboutReaderCb@resource://gre/modules/DownloadLegacy.jsm:438:19

Unassigning this work for now until we have more bandwidth to investigate test failures.

Flags: needinfo?(nbaumgardner)
Flags: needinfo?(burnha42)
Assignee: burnha42 → nobody
Status: REOPENED → NEW
You need to log in before you can comment on or make changes to this bug.