1651728 - Reader mode toolbar is saved with the document

Status: NEW

(Toolkit :: Reader Mode, defect, P3)

Description

[Panos Stokas]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Saved an html page while in Reader mode

Actual results:

The Reader mode toolbar was saved with the page

Expected results:

Only the Reader-mode-formatted page should have been saved. The toolbar is not part of the document, it's part of the user interface.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[burnha42]

Attachment: WIP: Bug 1651728 Remove reader mode toolbar from saved document. r=niklas,mtigley

Depends on D136067

Comment 3

[burnha42]

Attachment: WIP: Bug 1651728 Remove reader mode toolbar from saved document. r=niklas,mtigley

Comment 4

[burnha42]

Attachment: Bug 1651728 Remove reader mode toolbar from saved document. r=niklas,mtigley

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49df084db953
Remove reader mode toolbar from saved document. r=niklas,mtigley

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out changeset 49df084db953 (Bug 1651728) for causing lint failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Mz4xwgYbSC2K2lPLgyElIA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=49df084db95338978a6a4aa9d897bbe0f87053cf&searchStr=lint

Log: https://treeherder.mozilla.org/logviewer?job_id=371930580&repo=autoland

Backout: https://hg.mozilla.org/integration/autoland/rev/6deae1c1342ed5e3321bf2ad12c63ae306806e67

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:burnha42, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0aae935c87e2
Remove reader mode toolbar from saved document. r=niklas,mtigley

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0aae935c87e2

Comment 10

[Norisz Fay [:noriszfay]]

Backed out for causing Bug 1764182

Backout link

Push with failures

Failure log

Failure line(s): TEST-UNEXPECTED-FAIL | toolkit/components/reader/test/browser_readerMode_download.js | A promise chain failed to handle a rejection: JSWindowActorParent.sendQuery: JSWindowActorParent cannot send at the moment - stack: aboutReaderCb@resource://gre/modules/DownloadLegacy.jsm:438:19

Comment 11

[Norisz Fay [:noriszfay]]

Backout has been merged to central

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41bd981c3622
Remove reader mode toolbar from saved document. r=niklas,mtigley

Comment 13

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_readerMode_download.js

Backout link

Push with failures

Failure log

Failure line(s): TEST-UNEXPECTED-FAIL | toolkit/components/reader/test/browser_readerMode_download.js | A promise chain failed to handle a rejection: JSWindowActorParent.sendQuery: JSWindowActorParent cannot send at the moment - stack: aboutReaderCb@resource://gre/modules/DownloadLegacy.jsm:438:19

Comment 14

[Micah [:mtigley] (she/her)]

Unassigning this work for now until we have more bandwidth to investigate test failures.