Closed Bug 1651737 Opened 3 months ago Closed 2 months ago

Search Cache write delay is not working properly

Categories

(Firefox :: Search, defect, P2)

defect
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 80
Iteration:
80.1 - June 29 - July 12
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox78 --- unaffected
firefox79 --- unaffected
firefox80 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

The delay for writing the search cache is meant to be 1 second, however, it is currently "as soon as possible", as the value we are priming it is undefined:

https://searchfox.org/mozilla-central/rev/8d55e18875b89cdf2a22a7cba60dc40999c18356/toolkit/components/search/SearchCache.jsm#166

this._batchTask = new DeferredTask(task, this.CACHE_INVALIDATION_DELAY);

The CACHE_INVALIDATION_DELAY is actually a static member, so it should be accessed via SearchCache.CACHE_INVALIDATION_DELAY.

Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72aaa7fb6af1
Correct reference to the search cache invalidation delay. r=daleharvey
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
You need to log in before you can comment on or make changes to this bug.