1651750 - Remove ParserAtomId and ParserNameId, replace with pointers-to-parser-atoms.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[Kannan Vijayan [:djvj]]

Now that the parser-atoms patch is correct up to jit-tests, it's time to simplify for review.

This reasoning is explained across various comments in the main bug, but it serves to repeat it here.

Initially, ParserAtomId and ParserNameId were created and used because the original representation of parser-atom references were indexes into a table. As this approach
proved less desirable, the eventual (current) implementation saw these types become simple wrappers around pointers-to-ParserAtomEntry.

The pointer-ness of these ids is pretty explicit in the code now, and they do not serve any purpose except to get in the way of obtaining the pointer.

Comment 1

[Kannan Vijayan [:djvj]]

Attachment: Bug 1651750 - Remove ParserAtomId and ParserNameId, replace with pointers-to-parser-atoms. r?tcampbell

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/339f7ef099eb
Remove ParserAtomId and ParserNameId, replace with pointers-to-parser-atoms. r=tcampbell

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/339f7ef099eb