1651815 - Stop using CallNonGenericMethod for Date methods

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, enhancement, P2)

Description

[Tom S. (please needinfo tschuster)]

Similar to Bug 1651445 we should stop using CallNonGenericMethod here as well.

Compared to the Number functions this a bit more hairy, because we can't just operate on a double.
I think this is still fine, because all uses of the unwrapped Date object are extremely simple and only read/write slots on the NativeObject. We do have unwrapped object roots on the stack across gc-able calls, but from my understanding that is not actually a problem.
I consistently used unwrapped instead of dateObj or something similar to call attention to this potential footgun.

This review isn't urgent, I am going to be away.

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1651815 - Stop using CallNonGenericMethod for Date get methods. r?anba

Depends on D82785

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1651815 - Stop using CallNonGenericMethod for Date toString methods. r?anba

Depends on D82994

Comment 3

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1651815 - Split up getMilliseconds and getUTCMilliseconds to get better error messages. r?anba

Depends on D82995

Comment 4

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1651815 - Make toUTCString the default. r?anba

The spec says that toGMTString is the same function as toUTCString.
This was already the case Date.prototype.toGMTString == "toUTCString",
but the error message and naming was still wrong.

Depends on D82996

Comment 5

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1651815 - Implement ThisTimeValue for self-hosted Date methods. r?anba

Depends on D82997

Comment 6

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1651815 - Stop using CallNonGenericMethod for Date set methods. r?anba

Depends on D82998

Comment 7

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1651815 - Test. r?anba

Depends on D82999

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18b15d2d5aae
Stop using CallNonGenericMethod for Date get methods. r=anba
https://hg.mozilla.org/integration/autoland/rev/a649aaf2bb79
Stop using CallNonGenericMethod for Date toString methods. r=anba
https://hg.mozilla.org/integration/autoland/rev/18f9e72363dc
Split up getMilliseconds and getUTCMilliseconds to get better error messages. r=anba
https://hg.mozilla.org/integration/autoland/rev/55492e3dce5c
Make toUTCString the default. r=anba
https://hg.mozilla.org/integration/autoland/rev/9f4d1cf2f576
Implement ThisTimeValue for self-hosted Date methods. r=anba
https://hg.mozilla.org/integration/autoland/rev/d4dbc509ead5
Stop using CallNonGenericMethod for Date set methods. r=anba
https://hg.mozilla.org/integration/autoland/rev/aa80b7de92df
Test. r=anba

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/18b15d2d5aae
https://hg.mozilla.org/mozilla-central/rev/a649aaf2bb79
https://hg.mozilla.org/mozilla-central/rev/18f9e72363dc
https://hg.mozilla.org/mozilla-central/rev/55492e3dce5c
https://hg.mozilla.org/mozilla-central/rev/9f4d1cf2f576
https://hg.mozilla.org/mozilla-central/rev/d4dbc509ead5
https://hg.mozilla.org/mozilla-central/rev/aa80b7de92df