1651898 - MozPhab is failing to continue if user has empty primaryEmail field

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P2)

Description

[Piotr Zalewa [:zalun]]

The response["email"] is None.
MozPhab should warn the user and continue to work with Telemetry switched off.

DEBUG    2020-07-09 22:14:24,028 https://phabricator.services.mozilla.com/api/user.whoami {}
ERROR    2020-07-09 22:14:28,072 Traceback (most recent call last):
  File "c:\Users\Bas\Dev\mozilla-build\python3\lib\site-packages\mozphab\mozphab.py", line 73, in main
    telemetry.set_metrics(args, is_development=is_development)
  File "c:\Users\Bas\Dev\mozilla-build\python3\lib\site-packages\mozphab\telemetry.py", line 150, in set_metrics
    self.update_user_data()
  File "c:\Users\Bas\Dev\mozilla-build\python3\lib\site-packages\mozphab\telemetry.py", line 102, in update_user_data
    is_employee_changed = user_data.set_user_data()
  File "c:\Users\Bas\Dev\mozilla-build\python3\lib\site-packages\mozphab\user.py", line 96, in set_user_data
    whoami = self.whoami()
  File "c:\Users\Bas\Dev\mozilla-build\python3\lib\site-packages\mozphab\user.py", line 70, in whoami
    if response["email"].lower().endswith("@mozilla.com"):
AttributeError: 'NoneType' object has no attribute 'lower'

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: user: account for an empty `primaryEmail` field in Conduit response (Bug 1651898) r?zeid

It is possible for a user to have an empty primaryEmail field
in their Conduit response. Account for this potential state,
logging a warning that advises them to add a primary email in
their Phabricator settings. If they don't have a primary email
set, assume they are not an employee and return.