1651931 - Remove unnecessary includes from ContentChild.h

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task)

Description

[Simon Giesecke [:sg] [he/him]]

ContentChild.h is very expensive to include according to ClangBuildAnalyzer:

217505 ms: /home/simon/work/fuzzy/obj-x86_64-pc-linux-gnu-optimized/dist/include/mozilla/dom/ContentChild.h (included 105 times, avg 2071 ms), included via:
  FOGIPC.cpp  (5560 ms)
  DriverCrashGuard.cpp  (5230 ms)
  ChildSHistory.cpp  (5066 ms)
  ...

At the same time, it includes a look of expensive headers itself, not all of which seem to be really required.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1651931 - Remove unnecessary includes from ContentChild.h. r=nika

Before these changes, ContentChild.h was the #9 most expensive header to include:
217505 ms: /home/simon/work/fuzzy/obj-x86_64-pc-linux-gnu-optimized/dist/include/mozilla/dom/ContentChild.h (included 105 times, avg 2071 ms)

After these changes, it is no longer among the top 30 most expensive headers.

Some missing includes in other files are added along.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c1269889e8a
Remove unnecessary includes from ContentChild.h. r=nika

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0c1269889e8a