Closed Bug 1651970 Opened 2 years ago Closed 2 years ago

MozPhab is submitting the commit with an SHA1 before amend

Categories

(Conduit :: moz-phab, defect, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zalun, Assigned: zalun)

References

Details

(Keywords: conduit-triaged)

Attachments

(1 file)

MozPhab is amending the commit to change its summary.
Diff's metadata contains the SHA1 of the commit.

The original SHA1 of the submitted commit is used instead of the amended one.

phab@57dbb6b40352:~$ cd test-repo
phab@57dbb6b40352:~/test-repo$ echo A > README
phab@57dbb6b40352:~/test-repo$ hg commit -m A
phab@57dbb6b40352:~/test-repo$ moz-phab -b 1
Submitting 1 commit for review:
(New) 1:013420606a1d Bug 1 - A
!! Missing reviewers
Submit to http://phabricator.test (YES/No/Always)?

Creating new revision:
1:013420606a1d Bug 1 - A
1 new orphan changesets

Completed
(D61) 3:ed1479fd65f1 Bug 1 - A
-> http://phabricator.test/D61

First commit started with SHA1 013420606a1d, MozPhab amended it to ed1479fd65f1.
Phabricator is showing 013420606a1d.

Assignee: nobody → pzalewa

We amend commit description to add link to the Phabricator revision.
SHA1 along with other metadata was submitted to Phabricator before the
commit has been amended. This patch creates a new method
Diff::set_property() which is called after changing commit's SHA1.

Attachment #9165037 - Attachment description: Bug 1651970 - Save metadata after commit description is ammended. r=zeid → Bug 1651970 - Save metadata after commit description is amended. r=zeid
Assignee: pzalewa → nobody
Assignee: nobody → pzalewa
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Regressions: 1674310
You need to log in before you can comment on or make changes to this bug.