1652013 - Reorder columns in about:processes

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement)

Description

[David Teller [:Yoric] - still alive but not very active]

In about:processes, we currently show, in this order:

1. process id (or thread id);
2. process name and type;
3. resident memory;
4. virtual memory;
5. CPU use (user space);
6. CPU use (kernel space);
7. Number of threads.

We should reorder (skipping a few columns):

1. process name and type (which is what our users are most interested in);
2. resident memory;
3. total CPU use (user + kernel)
4. process id (or thread id);
5. number of threads.

This should make it easier for users to read the table.

The code is in aboutProcesses.html, aboutProcesses.js and aboutProcesses.css.

edit Added details.

Comment 1

[u608768]

Maybe something to consider: for narrower windows, the columns near the end get cutoff. Is it possible to make the columns resizable or something?

Hovering over the truncated field shows a tooltip with the value, so this isn't a huge deal. This might not even be a problem after bug 1648378.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1652013 - In default sorting, instead of sorting by pid, group together rows by type;r?florian

Comment 3

[David Teller [:Yoric] - still alive but not very active]

(In reply to :kashav from comment #1)

Maybe something to consider: for narrower windows, the columns near the end get cutoff. Is it possible to make the columns resizable or something?

That will take work, but yeah, I'd like to do that.

Comment 4

[Phabricator Automation]

Comment on attachment 9163810 [details]
Bug 1652013 - In default sorting, instead of sorting by pid, group together rows by type;r?florian

Revision D83668 was moved to bug 1652006. Setting attachment 9163810 [details] to obsolete.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1652013 - In default sorting, show a separation between groups of rows;r?florian

Depends on D83668

Comment 6

[Phabricator Automation]

Comment on attachment 9163810 [details]
Bug 1652013 - In default sorting, instead of sorting by pid, group together rows by type;r?florian

Revision D83668 was moved to bug 1652006. Setting attachment 9163810 [details] to obsolete.

Comment 7

[Phabricator Automation]

Comment on attachment 9164037 [details]
Bug 1652013 - In default sorting, show a separation between groups of rows;r?florian

Revision D83790 was moved to bug 1652006. Setting attachment 9164037 [details] to obsolete.

Comment 8

[jacobmarquardt1]

Hi! I've never contributed to OSS before, but I'd love to take a crack at this since it appears to be unassigned. Where do I begin?

Comment 9

[David Teller [:Yoric] - still alive but not very active]

(In reply to jacobmarquardt1 from comment #8)

Hi! I've never contributed to OSS before, but I'd love to take a crack at this since it appears to be unassigned. Where do I begin?

Hey, jacobmarquardt1, thanks for picking this!

The first step would be to be download and build the source code of Firefox, then to configure Phabricator, the tool we use to submit changes to Firefox. If you have any question, you can find me (and plenty of other nice people) on our chat! Over there, I'm called Yoric.

Comment 10

[Sonia Singla :soniasingla]

Hey, Yoric, I am working on this bug :)

Comment 11

[David Teller [:Yoric] - still alive but not very active]

Great :)

I'll be away for a few days but don't hesitate to ask questions here or on #Introduction if you need help!

Comment 12

[Sonia Singla :soniasingla]

Attachment: Bug 1652013 - Reorder columns in about:processes. r=yoric

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1527aeaa9d1
Reorder columns in about:processes. r=Yoric,fluent-reviewers,flod,florian

Comment 14

[Cristina Coroiu [:ccoroiu]]

Backed out changeset c1527aeaa9d1 (bug 1652013) for bc failures at toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses.js

Backout: https://hg.mozilla.org/integration/autoland/rev/325966c58ad27142169c9794bd551ad8fadbc091

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c1527aeaa9d15aed092f97de1c683fd9a768837f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313539916&repo=autoland&lineNumber=51808

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b73b2f9e7f1d
Reorder columns in about:processes. r=Yoric,fluent-reviewers,flod,florian

Comment 16

[Razvan Maries]

Backed out for causing bug 1660624 as requested by David.

Backout: https://hg.mozilla.org/integration/autoland/rev/4a3fa34ca3256479bd16363a80d950d35ce0ae96

Comment 17

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b73b2f9e7f1d

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f173105b595b
Reorder columns in about:processes. r=Yoric,fluent-reviewers,flod,florian

Comment 19

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f173105b595b