1652032 - Windows arm64 cross compiling using msvc + makefiles fails

Status: RESOLVED FIXED

(NSS :: Build, defect, P1)

Description

[Jan-Marek Glogowski]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

I'm currently working on cross-compiling LibreOffice from Windows x86_64 to arm64. One of the dependencies is NSS / NSPR, which fails to build in my setup.

I also had a look into the repo, but couldn't find any patch looking like a fix.

Actual results:

Compilation failed.

Expected results:

Compilation works.

Comment 1

[Jan-Marek Glogowski]

Attachment: Bug 1656187 Allow cross-compiling to cygwin

This is needed to cross compile on x86_64 cygwin to arm64 using
MSVC compiler.

Comment 2

[Jan-Marek Glogowski]

Attachment: Bug 1652032 Disable all freebl assembler code for MSVC arm64

There are two places, where NSS tries to compile either x86_64
MSVC assembler or GCC aarch64 code, which will fail the build.
And also drop the non-MSVC arch build flags for them.

AFAI could identify, there isn't any armasm64 compatible asm
code in the whole NSS library, so I don't even adapt AS for the
build. The cross-build finishes this way.

Comment 3

[Kevin Jacobs [:kjacobs]]

https://hg.mozilla.org/projects/nss/rev/d98bbb6168f4ca2abd534e4c2fce56b7a5d1ad7e

Comment 4

[Jan-Marek Glogowski]

FYI: the NSPR part of the fix is still not merged, so the build will still fail.

Comment 5

[Kai Engert [:KaiE:]]

(In reply to Jan-Marek Glogowski from comment #4)

FYI: the NSPR part of the fix is still not merged, so the build will still fail.

where is the nspr part?

A separate nspr bug report should be filed with the suggested change to nspr. please CC me.

Comment 6

[Phabricator Automation]

Comment on attachment 9162830 [details]
Bug 1656187 Allow cross-compiling to cygwin

Revision D83118 was moved to bug 1656187. Setting attachment 9162830 [details] to obsolete.

Comment 7

[Phabricator Automation]

Comment on attachment 9162857 [details]
Bug 1652032 Disable all freebl assembler code for MSVC arm64

Revision D83137 was moved to bug 1655105. Setting attachment 9162857 [details] to obsolete.