1652041 - Remove Intervention for twitter.com videos that have cookies blocked

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, task, P3)

Description

[Oana Arbuzov [:oanaarbuzov]]

Attachment: Screenshot_1.png

I've checked some videos from the reported issues on Bugzilla, and they seem to work with the Intervention disabled.

URL: https://www.theverge.com/2020/5/27/21271927/uber-jump-bike-scooter-scrap-photos-video-lime-junkyard
URL: https://www.nytimes.com/2020/05/28/us/george-floyd-national-guard.html

Environment:
Browser / Version: Firefox Nightly 80.0a1 (2020-07-09)
Operating System: Windows 10 Pro

If embedded Twitter videos play and we can't find any that are broken, the Intervention can be removed.
Mike please confirm to this.

Comment 1

[Mike Taylor [:miketaylr]]

I think before removing this one we need to verify that it isn't being fixed by the blocklist/allowlist changes (or whatever mechanism it was) implemented by Steven in Bug 1641969.

Steven, is there a way we can disable that for testing?

Comment 2

[Steven Englehardt [:englehardt]]

(In reply to Mike Taylor [:miketaylr] from comment #1)

I think before removing this one we need to verify that it isn't being fixed by the blocklist/allowlist changes (or whatever mechanism it was) implemented by Steven in Bug 1641969.

Steven, is there a way we can disable that for testing?

Yes you can follow the steps listed here: https://bugzilla.mozilla.org/show_bug.cgi?id=1641998#c2.

In fact, I was going to check in with you folks to check whether the webcompat fix has shipped and if we can remove the intervention from our side. The webcompat intervention is preferred because it doesn't exempt the domain from tracking protection (like ours does).

Comment 3

[Mike Taylor [:miketaylr]]

Thanks Steven. Let's get Oana just to double check, but I assume that once she uses the steps from https://bugzilla.mozilla.org/show_bug.cgi?id=1641998#c2 that we will want to keep the intervention.

Oana, can you re-test? If the bug still exists, we can close this bug.

Comment 4

[Oana Arbuzov [:oanaarbuzov]]

Mike, with the setting services.settings.default_bucket set to foo in about:config, I'm still able to play the videos, regardless if twitter.com intervention is enabled or disabled.

Environment:
Browser / Version: Firefox Nightly 80.0a1 (2020-07-12)
Operating System: Windows 10 Pro

Comment 5

[Mike Taylor [:miketaylr]]

if we can remove the intervention from our side.

Steven, yes, y'all can remove it from your side, thanks!

It seems like Twitter fixed on their end, but let's delay one more release before removing this intervention just to be safe (since it's not hurting anything to have it enabled).

Comment 6

[Steven Englehardt [:englehardt]]

(In reply to Mike Taylor [:miketaylr] from comment #5)

if we can remove the intervention from our side.

Steven, yes, y'all can remove it from your side, thanks!

It seems like Twitter fixed on their end, but let's delay one more release before removing this intervention just to be safe (since it's not hurting anything to have it enabled).

Thanks! I've removed the anti-tracking intervention and have verified that the breakage is fixed (including when the webcompat intervention is disabled)

Comment 7

[Mike Taylor [:miketaylr]]

Great, thank you!

Comment 8

[Ksenia Berezina [:ksenia]]

This was removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1649243