SVGGenericContainerFrame.cpp might be dead code
Categories
(Core :: SVG, task, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: dholbert, Assigned: longsonr)
References
()
Details
Attachments
(1 file)
When reviewing https://phabricator.services.mozilla.com/D83140, I noticed a code-coverage lint note saying that SVGGenericContainerFrame.cpp is un-covered.
Perhaps it's dead code & needs removing? (Or if not, we should probably add some testcases that exercise it.)
Link to the relevant file:
https://searchfox.org/mozilla-central/source/layout/svg/SVGGenericContainerFrame.cpp
|
Reporter | |
Updated•4 years ago
|
|
Assignee | |
Comment 1•4 years ago
|
||
You'd need a <generic> element I think. https://searchfox.org/mozilla-central/source/layout/base/nsCSSFrameConstructor.cpp#5018
That's was xul/xbl thing wasn't it. Is that all dead now?
|
|
Reporter | |
Comment 2•4 years ago
|
||
XUL still exists, but we're not thrilled with that, and we're intending to remove it when we can (which involves lots of porting, rewriting, and/or emulation).
XBL is dead; https://bgrins.github.io/xbl-analysis/ says XBL bindings are all gone from the tree.
(I'm not familiar with the <generic> element, but if it was a XUL/XBL thing, then I think it's safe to say we don't care about it & we should remove it as long as nothing's using it, and I think this code-coverage linter indicates that indeed nothing's using it.)
|
|
Assignee | |
Comment 3•4 years ago
|
||
|
||
Updated•4 years ago
|
Pushed by longsonr@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5e9a7815de71 Remove SVGGenericContainerFrame r=jwatt
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Description
•