Closed Bug 1652207 Opened 4 years ago Closed 4 years ago

Make IntCoordTyped and CoordTyped derive from units.

Categories

(Core :: Graphics: Layers, task)

task

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(1 file)

// Note: 'IntCoordTyped<units>' and 'CoordTyped<units>' do not derive from
// 'units' to work around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61959.

https://searchfox.org/mozilla-central/rev/622dbd3409610ad3f71b56c9a6a92da905dab0aa/gfx/2d/Coord.h#88-89

I believe we no longer need above workaround since our minimum GCC version is 7.1 per
https://groups.google.com/forum/#!msg/mozilla.dev.platform/ygj-1MDVB4M/CLxE_7OcBAAJ

The GCC versions we needed to work around are no longer supported. Our
current minimum requirement for GCC is 7.1 per
https://groups.google.com/forum/#!msg/mozilla.dev.platform/ygj-1MDVB4M/CLxE_7OcBAAJ

Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7c2df2ae1ac5 Make IntCoordTyped and CoordTyped derive from units. r=botond
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: