Closed Bug 1652213 Opened 3 months ago Closed 3 months ago

File | Email Link… shows none of the mail handlers defined for mailto: when "Always Ask" is selected

Categories

(Firefox :: File Handling, defect, P1)

79 Branch
Desktop
All
defect

Tracking

()

VERIFIED FIXED
Firefox 80
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox78 --- unaffected
firefox79 --- verified
firefox80 --- verified

People

(Reporter: bugzilla, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression)

Attachments

(4 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

Selecting File | Email Link when mailto: under Applications in about:preferences is set to "Always Ask"

Actual results:

A blank dialog is presented with no options available other than "Choose Application", even when other mailto: handlers exist.

Expected results:

The mailto: handlers defined under Applications in about:preferences should be available as options. The dialog box probably should have a title rather than being blank, as well.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Preferences

Does the same thing happen if you click a mailto: link in a web page?

Do any errors appear in the browser console (cmd-shift-j) when you click the "email link" entry?

Flags: needinfo?(bugzilla)

Never mind, I can reproduce. Looks like bug 1606797 regressed this -- though thank goodness it's not on 78/78esr (verified locally on a non-ESR build) because we uplifted the fix without adding the origin label to the dialog when opened from a webpage: that's what's breaking this.

Assignee: nobody → gijskruitbosch+bugs
Severity: -- → S2
Status: UNCONFIRMED → ASSIGNED
Component: Preferences → File Handling
Ever confirmed: true
Flags: needinfo?(bugzilla)
Keywords: regression
OS: Unspecified → All
Priority: -- → P1
Regressed by: 1606797
Hardware: Unspecified → Desktop
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/52f13a5c2e22
invoking the external helper app dialog without a principal shouldn't throw, r=mconley

Comment on attachment 9163383 [details]
Bug 1652213 - invoking the external helper app dialog without a principal shouldn't throw, r?mconley!

Beta/Release Uplift Approval Request

  • User impact if declined: Broken UI
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): I'm adding 1 (one) character, to nullcheck an incoming argument that we already nullcheck later on. Too bad we don't have JS dataflow analysis or this couldn't have landed as it was originally...
  • String changes made/needed: nope
Attachment #9163383 - Flags: approval-mozilla-beta?
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80

Comment on attachment 9163383 [details]
Bug 1652213 - invoking the external helper app dialog without a principal shouldn't throw, r?mconley!

Approved for 79.0b8.

Attachment #9163383 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

I couldn't manage to reproduce the issue in order to verify it on MacOS 10.14, I tried on Firefox 79.0b6, 79.0b5 and on Firefox 80.0a1 (2020-07-10).
In about:preferences I set "Always Ask" to applications, the dialog box after accessing mailto: appeared correctly. (Please see the screenshot attached)

Are there any extra steps that's need to be done in order to reproduce it?
Thanks.

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Hani Yacoub from comment #11)

Created attachment 9164053 [details]
Screenshot 2020-07-16 at 14.47.06.png

I couldn't manage to reproduce the issue in order to verify it on MacOS 10.14, I tried on Firefox 79.0b6, 79.0b5 and on Firefox 80.0a1 (2020-07-10).
In about:preferences I set "Always Ask" to applications, the dialog box after accessing mailto: appeared correctly. (Please see the screenshot attached)

Are there any extra steps that's need to be done in order to reproduce it?
Thanks.

You need to use the File menu as in the steps in comment #0 - you're clicking a link on a webpage instead (the dialog says so).

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(hani.yacoub)

Thanks!
Verified on Firefox 80.0a1 (2020-07-16) and on Firefox 79.0b8 on Windows 10 x64, MacOS 10.14 and un Ubuntu 20.04.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
Flags: needinfo?(hani.yacoub)
You need to log in before you can comment on or make changes to this bug.