1652220 - [CSD] Titlebar fails to switch to inactive style

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[joshas]

Attachment: firefox-titlebar-csd-active.png

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Turn off "Title bar" option in customization window. Alt+tab to another program with smaller window, e.g. Calculator, or just start another program that opens new window.

Actual results:

Firefox titlebar (one with all tabs and close button) color remains in "active" style while window is actually in background. (top part of attached screenshot)

Expected results:

After opening new program or switching to another window Firefox titlebar must instantly update to correct "inactive" style.
While other program window is active and Firefox window is visible moving mouse over Firefox titlebar (titlebar only, just moving over Firefox window does not update titlebar style) causes it to refresh and display in correct "inactive" style. (bottom part of attached screenshot)
Fedora 32 with Wayland.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Yes, I do see that too. We fails to repaint the titlebar.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

It's caused by https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0bc4d93567a76664acb2a5ba1fc081a4f0ec31f2&tochange=9eb877be55acd8b5e27ea70a4d766946d5d8e60a
Looks like the widget cache can't deliver inactive titlebar state so we always draw it as active.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1652220 [Linux] Create titlebar style from actual widget, r?jhorak

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1652220 [Linux] Clean up titlebar setup, r?jhorak

• Ask for alpha visual for toplevel windows on composited screens only.
• Rename TitlebarCanUseShapeMask() to TitlebarUseShapeMask() to control titlebar shape mask usage.
• Allow to use shape mask under widget.titlebar-x11-use-shape-mask preference, it's off by default.
• Simplify HideTitlebarByDefault(), remove compositing/shape mask check as we use RGBA visual only now.

Depends on D98597

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1e8f63ae036dd6f4c3e21964a1525ad69cb99eb

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad5f28dbb4dc
[Linux] Create titlebar style from actual widget, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/2783a73bd4ec
[Linux] Clean up titlebar setup, r=jhorak

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/ad5f28dbb4dc
https://hg.mozilla.org/mozilla-central/rev/2783a73bd4ec

Comment 9

[Martin Stránský [:stransky] (ni? me)]

This patch causes a regression - a black background is painted as a border over whole window so we don't utilize opaque region and the titlebar corners are gray. I guess it's related to the window style, will look at it.