Closed Bug 1652337 Opened 4 years ago Closed 4 years ago

Prevent script from calling nsIWebBrowserPrint.print()

Categories

(Core :: Printing: Setup, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

(Whiteboard: [print2020_v80])

Attachments

(1 file)

No description provided.

There is only one "caller" left in the dead code that should be removed by bug 1641805. I don't have the time to figure out a proper patch to that bug right now, but that shouldn't stop us marking this API [noscript] to make reviews of changes to its implementation easier to review.

Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/7d6fb29b9f05
Prevent script from calling nsIWebBrowserPrint.print(). r=bobowen

Backed out for failures on browser_DownloadPDFSaver.js along with Bug 1652322 and Bug 1652318

backout: https://hg.mozilla.org/integration/autoland/rev/22f5f7e914449bde3bee21a322d67248cd5e0254

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=7d6fb29b9f05ec9fd8c2f1d6ead8bc20402f78f5&searchStr=browser-chrome&selectedTaskRun=EHkXumWFTIOcBKMBS06A0Q.0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309507781&repo=autoland&lineNumber=39154

[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - TEST-PASS | toolkit/components/downloads/test/browser/browser_DownloadPDFSaver.js | Download window reference is a weak ref -
[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - TEST-PASS | toolkit/components/downloads/test/browser/browser_DownloadPDFSaver.js | Download window exists during test -
[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - Buffered messages finished
[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/downloads/test/browser/browser_DownloadPDFSaver.js | Uncaught exception - DownloadError: this._webBrowserPrint.print is not a function
[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - Stack trace:
[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - DownloadError@resource://gre/modules/DownloadCore.jsm:1696:16
[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - D_start/<@resource://gre/modules/DownloadCore.jsm:557:20
[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - Leaving test bound test_createDownload_pdf_private
[task 2020-07-12T16:05:38.688Z] 16:05:38 INFO - Entering test bound test_createDownload_pdf_not_private

Flags: needinfo?(jwatt)
Flags: needinfo?(jwatt)
Whiteboard: [print2020_v80] → [print2020_v81]
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/6358f151511f
Prevent script from calling nsIWebBrowserPrint.print(). r=bobowen
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Whiteboard: [print2020_v81] → [print2020_v80]
Whiteboard: [print2020_v80] → [print2020_v81]
Whiteboard: [print2020_v81] → [print2020_v80]
Depends on: 1641805
Blocks: 1587459
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: