1652344 - Stop creating an nsIPrintSettings in nsGlobalWindowOuter::PrintOuter

Status: RESOLVED FIXED

(Core :: Printing: Setup, task, P1)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1652344 p1. Remove the code in nsGlobalWindowOuter::PrintOuter for handling failure to get an nsIPrintSettingsService. r=bobowen

All our backends implement nsIPrintSettingsService, so this code is unused.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Bug 1652344 p3. Stop creating an nsIPrintSettings in nsGlobalWindowOuter::PrintOuter. r=bobowen

The fallback code in nsPrintJob::DoCommonPrint to create an nsIPrintSettings if
none is passed in is never used, since all callers pass a settings object.
However, to simplify future changes I'd like nsGlobalWindowOuter::PrintOuter to
stop creating and passing in its own default valued nsIPrintSettings object.

This patch makes the fallback code that DoCommonPrint calls do what
nsGlobalWindowOuter::PrintOuter does, and makes the latter stop passing in a
settings object.

This patch also removes nsIWebBrowserPrint.globalPrintSettings since
nsGlobalWindowOuter::PrintOuter was its only consumer.

Depends on D83267

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/075903436ef2
p1. Remove the code in nsGlobalWindowOuter::PrintOuter for handling failure to get an nsIPrintSettingsService. r=bobowen
https://hg.mozilla.org/integration/autoland/rev/d2b66d810ab5
p2. Stop creating an nsIPrintSettings in nsGlobalWindowOuter::PrintOuter. r=bobowen

Comment 4

[Alexandru Michis [:malexandru]]

Backed out 2 changesets for causing failures in test_printpreview.xhtml

Backout link: https://hg.mozilla.org/integration/autoland/rev/52aae6784eb346ee86af8d1f13cdb8965c3a47be

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=windows%2C7%2Cdebug%2Cmochitests%2Cwithout%2Ce10s%2Ctest-windows7-32%2Fdebug-mochitest-chrome-1proc-1%2Cm-1proc%28c1%29&tochange=52aae6784eb346ee86af8d1f13cdb8965c3a47be&fromchange=ccb87a635c596be630a9b6f552649fff85db1693&selectedTaskRun=dO83RI2fSFOkJwo0AmdLgA.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309523121&repo=autoland&lineNumber=116048

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2591c221cff
p1. Remove the code in nsGlobalWindowOuter::PrintOuter for handling failure to get an nsIPrintSettingsService. r=bobowen

Comment 6

[Jonathan Watt [:jwatt]]

Attachment: Bug 1652344 p2. Fix the print settings creation in the print preview tests. r=hiro

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20c29266e1df
p2. Fix the print settings creation in the print preview tests. r=hiro
https://hg.mozilla.org/integration/autoland/rev/24fb0d980a2e
p3. Stop creating an nsIPrintSettings in nsGlobalWindowOuter::PrintOuter. r=bobowen

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d2591c221cff
https://hg.mozilla.org/mozilla-central/rev/20c29266e1df
https://hg.mozilla.org/mozilla-central/rev/24fb0d980a2e