1652376 - Reduce size of interning handles

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1652376 - Reduce size of interning handles.

This reduces the size of intern handles, which drops the size of
the PrimitiveInstance structure from 80 bytes to 64 bytes. This
has a significant performance improvement on pages with large
numbers of primitives.

It also opens up some future optimization work related to text
run interning costs, which will be a performance win on many pages.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fbefca418f3
Reduce size of interning handles. r=Bert

Comment 3

[Atila Butkovits]

Backed out changeset for causing failure at test_file_delete.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/0b270ed6f92d79b577ab4523c40a6c0e3d160cb5

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Dqo_aAIDTnaK2VN_A4jslg.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=7fbefca418f395f90429a2d0acb09720578c8f46

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309652575&repo=autoland&lineNumber=5520

Comment 4

[Glenn Watson [:gw]]

The failures in that link are caused by a different patch on autoland. I'll try re-landing this shortly, after discussing with the sheriffs.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c019e0c77d80
Reduce size of interning handles. r=Bert

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c019e0c77d80

Comment 7

[Florin Strugariu [:Bebe]]

== Change summary for alert #26506 (as of Tue, 14 Jul 2020 09:19:49 GMT) ==

Improvements:

3% displaylist_mutate linux64-shippable-qr opt e10s stylo 3,133.04 -> 3,024.04

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26506