Closed
Bug 1652440
Opened 5 years ago
Closed 5 years ago
adjust devtools tests to have is(...) statements work when evaluating with Object.is instead of ==
Categories
(DevTools :: General, task)
DevTools
General
Tracking
(firefox80 fixed)
RESOLVED
FIXED
Firefox 80
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file)
in bug 1647187 we are changing the is() to be Object.is(a, b) instead of a == b, this is breaking many tests. I have updated the devtools tests which appear to work well in the current a == b mode as well as Object.is(a, b).
I am not sure if I am breaking tests or using the proper code to do the job, but I suspect what I have is really close.
|
Assignee | |
Comment 1•5 years ago
|
||
adjust devtools to work with object.is() instead of ==
|
||
Updated•5 years ago
|
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
|
|
||
Updated•5 years ago
|
Attachment #9163168 -
Attachment description: Bug 1652440 - adjust devtools to work with object.is() instead of ==. r=jlast → Bug 1652440 - adjust devtools to work with object.is() instead of ==. r=rcaliman
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/706c6ceab982
adjust devtools to work with object.is() instead of ==. r=rcaliman,jdescottes
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
You need to log in
before you can comment on or make changes to this bug.
Description
•