1652499 - ThreadSanitizer: data race [@ UpdateMinLogSeverity] vs [@ Loggable]

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Byron Campen [:bwc]]

Attachment: tsan output

This is down in webrtc.org. Logging only, so probably not too dangerous. Probably makes sense to suppress.

Comment 1

[Byron Campen [:bwc]]

I'm guessing it probably makes sense to suppress this, and once we update webrtc.org, see if we still need the suppression.

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1652499: Suppress TSan race detection in webrtc.org's Loggable. r?dminor

Comment 3

[Byron Campen [:bwc]]

Try looks good.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=80b0d8448258efa636b6e55d0e1b3118cf87ab97&selectedTaskRun=NO2r6QZQSK2qY0XJ9KXU1A.0

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8867ea045e20
Suppress TSan race detection in webrtc.org's Loggable. r=dminor

Comment 5

[Christian Holler (:decoder)]

Byron, the suppression you added here is likely too broad. Please keep in mind that any race: entry applies to every part of the stack. And I think Loggable is a bit too generic.

In this particular case, you could match on the global variable rtc::LogMessage::min_sev_ that is being mentioned in the race report with a single race: line. Can you please make the necessary adjustment? Thanks

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8867ea045e20