Closed Bug 1652499 Opened 1 year ago Closed 1 year ago

ThreadSanitizer: data race [@ UpdateMinLogSeverity] vs [@ Loggable]

Categories

(Core :: WebRTC: Audio/Video, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: bwc, Assigned: bwc, NeedInfo)

References

Details

Attachments

(2 files)

Attached file tsan output

This is down in webrtc.org. Logging only, so probably not too dangerous. Probably makes sense to suppress.

I'm guessing it probably makes sense to suppress this, and once we update webrtc.org, see if we still need the suppression.

Assignee: nobody → docfaraday
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8867ea045e20
Suppress TSan race detection in webrtc.org's Loggable. r=dminor

Byron, the suppression you added here is likely too broad. Please keep in mind that any race: entry applies to every part of the stack. And I think Loggable is a bit too generic.

In this particular case, you could match on the global variable rtc::LogMessage::min_sev_ that is being mentioned in the race report with a single race: line. Can you please make the necessary adjustment? Thanks

Flags: needinfo?(docfaraday)
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.