1652522 - Multi-Account Containers: allow 'Reopen This Site in…' to override current settings

Status: RESOLVED MOVED

(Core :: DOM: Security, enhancement)

Description

[Adam Alton]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Using Multi-Account Container version 7.0.0.

Scenario 1 (using Gmail as an example):

1. Set up Mutli-Account containers and create a container called "Google".
2. Go to https://mail.google.com and sign in to Gmail if not already signed in.
3. Click on the Mutli-Account Containers menu and choose "Always Open This Site in…" and set mail.google.com to always open in the "Google" container.
4. In the Mutli-Account Containers menu to to "Manage Containers" => "Google" and check "Limit to Designated Sites".
5. Open https://mail.google.com in a new tab just to confirm the decision to assign it to the "Google" container.
6. Log out of Gmail.
7. Try to sign into Gmail again. The domain accounts.google.com is not assigned to the Google container, and the "Limit to Designated Sites" option is checked, so it opens in the default container instead.
8. Right click on the tab in the tab bar and choose "Reopen in Container" => "Google".
9. In the Mutli-Account Containers menu to to "Manage Containers" => "Google" => "Manage Site List…" and try to add accounts.google.com to the list of sites for the "Google" container.

Actual results:

At step 7, despite explicitly choosing to reopen the tab in the "Google" container, my chosen settings are enforced upon me. I get that I've chosen those settings, but it would be nice if when explicitly choosing to re-open the site in a specific container that this action overrides those settings.

Perhaps this could be done with a confirmation page. Currently it just re-opens the page in a new tab but ignores the container you've chosen. So "Reopen in container" is half honoured - reopened, but not in that container!

At step 8, there is no option to add another domain to the list. Intuitively it would make sense to me that clicking on "Manage Site List…" allows me to add new sites as well as remove existing ones.

Expected results:

(See above.)

Comment 1

[Adam Alton]

Note that the enforcement of container assignments also applies even without the "Limit to Designated Sites" option. If you've set "Always Open This Site in…" for a particular domain, then choosing "Reopen in Container" for a page on that domain will always just open a duplicate tab in the existing container.

Comment 2

[Virginia (please send need info request to Brindusa Tot)]

Hi Adam,

Thanks for your report.

I'll add this to the DOM Security product so their team can make some research on it. Hopefully, someone with a more deep understanding of this matter can help.

Regards,
Virginia

Comment 3

[Daniel Veditz [:dveditz]]

Hi Maxx: this bug is I believe in the front-end of MAC and not the contextual identity DOM code. Assigning this to you so you can move this request to the appropriate github issue. Once we have that filed we can resolve this bug "MOVED"

Comment 4

[Maxx Crawford [:maxx]]

Moved to GithHub - https://github.com/mozilla/multi-account-containers/issues/1834

Thanks, :dveditz!

Comment 5

[Daniel Veditz [:dveditz]]

Thanks!