Closed Bug 1652550 Opened 4 years ago Closed 4 years ago

Disable RenderExternalTextureHost when BufferTextureHost is wrapped with GPUVideoTextureHost

Categories

(Core :: Graphics: WebRender, defect, P1)

Unspecified
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: mikokm, Assigned: mikokm)

References

Details

Attachments

(1 file)

With some codecs, we end up with WebRenderTextureHost which wraps GPUVideoTextureHost which wraps BufferTextureHost. For some reason, these cases do not trigger PrepareForUse messages, which caused video to sometimes loop.

To limit the scope of changes, this patch disables Client Storage backed RenderExternalTextureHost in these situations.
A better solution would be to ensure that PrepareForUse messages are sent, or to not wrap BufferTextureHost with GPUVideoTextureHost when decoder does not benefit from it.

See Also: → 1536515
Pushed by mikokm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8b0345ec0299
Disable RenderExternalTextureHost when BufferTextureHost is wrapped with GPUVideoTextureHost r=mattwoodrow
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Regressions: 1658113
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: