1652568 - Fix failing DOM:Networking mochitests with cross-origin and Fission enabled

Status: RESOLVED WORKSFORME

(Core :: DOM: Networking, defect, P1)

Description

[Neha Kochar [:neha]]

These tests are marked as skipped/failed for cross-origin and Fission, and need to be fixed
dom/xhr/tests/test_XHRDocURI.html
dom/xhr/tests/test_worker_xhr_parameters.html

https://docs.google.com/spreadsheets/d/16G5AZhHWWow3rBgim4QBHzWXMIIJiky2SzXYgDMTTKY/edit#gid=1354562828&range=25:27

More info: https://wiki.mozilla.org/Project_Fission/Enabling_Tests_with_Fission#Cross-Origin_Mochitests

Comment 1

[Neha Kochar [:neha]]

Nhi, please assign someone to look into these failures. If the failure is because of a broken functionality with Fission enabled, then that must be fixed for M6b (Fx82) and if it is because of a broken test, then that can be done a little later but before Fission beta later this year so should be tracked separately for M7.

Comment 2

[Junior [inactive]]

dom/xhr/tests/test_XHRDocURI.html is blocked by session history (Bug 1467221)
I'll take a look at dom/xhr/tests/test_worker_xhr_parameters.html

Comment 3

[Valentin Gosu [:valentin] (he/him)]

(In reply to Junior [:junior] from comment #2)

dom/xhr/tests/test_XHRDocURI.html is blocked by session history (Bug 1467221)

Marking as blocked on bug 1467221

I'll take a look at dom/xhr/tests/test_worker_xhr_parameters.html

This actually seems to work now 🙂

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1652568 - Enable test_worker_xhr_parameters.html for xorigin fission r=kmag

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fdd97a2bd5b
Enable test_worker_xhr_parameters.html for xorigin fission r=kmag

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5fdd97a2bd5b

Comment 7

[Neha Kochar [:neha]]

The one pending test is yet to be triaged into M6b or M6c, depending on the debugging result so moving this main meta to M6c for now.

Comment 8

[Valentin Gosu [:valentin] (he/him)]

For some reason test_worker_xhr_parameters.html always passes locally with fission xorigin enabled but not on try.
It's not clear to me why.

Comment 9

[Valentin Gosu [:valentin] (he/him)]

It seems bug 1668357 removed the skip-if and it stuck.
Thanks Olli!