Closed Bug 1652609 Opened 4 years ago Closed 4 years ago

jwcrypto:generateJWE should include `kid` in the JWE header, if available

Categories

(Firefox :: Sync, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 80
Tracking Status
firefox80 --- fixed

People

(Reporter: rfkelly, Assigned: rfkelly)

References

Details

Attachments

(1 file)

This is a spinoff from Bug 1635657 which should have a different and separate review, because crypto.

When making a JWE, if the provided peer public key has a kid property, then we should echo that kid back in the JWE header. This helps consumers of the JWE to identify the correct key with which to decrypt it.

I'm also going to include some cleanups of the code that :m_and_m suggested in initial review of Bug 1635657.

Blocks: 1635657
Assignee: nobody → rfkelly
Attachment #9163368 - Attachment description: Bug 1652609 - When generating a JWE, include `kid` of the target key if known. :m_and_m,:lina → Bug 1652609 - When generating a JWE, include `kid` of the target key if known. r?:m_and_m,:lina
Pushed by rkelly@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd5b31b3b27c
When generating a JWE, include `kid` of the target key if known. r=m_and_m,lina:m_and_m,:lina
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: