Closed Bug 1652624 Opened 4 years ago Closed 4 years ago

[jsdbg2] The debugger wrapper types should expose a consistent owner and referent API

Categories

(Core :: JavaScript Engine, task, P2)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: loganfsmyth, Assigned: loganfsmyth)

Details

Attachments

(2 files)

Bug 1652624 - Part 1: Explicitly access owner slot for debugger child types. r=arai!
47 bytes, text/x-phabricator-request
Details | Review
Bug 1652624 - Part 2: Avoid direct getPrivate usage on debugger children. r=arai!
47 bytes, text/x-phabricator-request
Details | Review

The debugger's wrapper types have an inconsistent API right now that sometimes directly relies on shared slot indicies and getPrivate which is ugly and makes things harder to refactor. These things should be exposed using consistent APIs.

Severity: -- → S4
Priority: -- → P2
Pushed by loganfsmyth@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e7744c0001b4
Part 1: Explicitly access owner slot for debugger child types. r=arai
https://hg.mozilla.org/integration/autoland/rev/0f81506f1d57
Part 2: Avoid direct getPrivate usage on debugger children. r=arai

Backed out 4 changesets (bug 1652623, bug 1652625, bug 1652624) for Debugger.h related bustage

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=32bac254e9a8ae5182af35fd1ea388074cb1ea07&searchStr=build&tochange=cb3c56d58d817cebd1789872d5dcf1b13c1fed13&selectedTaskRun=EiCyXmhLRW-vMhL5jcTNqA.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/cb3c56d58d817cebd1789872d5dcf1b13c1fed13

Failures logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309940980&repo=autoland&lineNumber=6311

[task 2020-07-16T01:26:03.608Z] Running heapwrites to generate heapWriteHazards.txt
[task 2020-07-16T01:26:03.608Z] LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:/builds/worker/workspace/obj-haz-shell/dist/bin" PATH="/builds/worker/fetches/sixgill/usr/bin:${PATH}" XDB='/builds/worker/fetches/sixgill/usr/bin/xdb.so' SOURCE='/builds/worker/checkouts/gecko' ANALYZED_OBJDIR='/builds/worker/workspace/obj-analyzed' /builds/worker/workspace/obj-haz-shell/dist/bin/js /builds/worker/checkouts/gecko/js/src/devtools/rootAnalysis/analyzeHeapWrites.js > heapWriteHazards.txt
[task 2020-07-16T01:26:06.699Z] + check_hazards /builds/worker/workspace/analysis
[task 2020-07-16T01:26:06.699Z] + set +e
[task 2020-07-16T01:26:06.700Z] ++ grep -c 'Function.*has unrooted.*live across GC call' /builds/worker/workspace/analysis/rootingHazards.txt
[task 2020-07-16T01:26:06.701Z] + NUM_HAZARDS=1
[task 2020-07-16T01:26:06.701Z] ++ grep -c '^Function.*takes unsafe address of unrooted' /builds/worker/workspace/analysis/refs.txt
[task 2020-07-16T01:26:06.702Z] + NUM_UNSAFE=74
[task 2020-07-16T01:26:06.703Z] ++ grep -c '^Function.* has unnecessary root' /builds/worker/workspace/analysis/unnecessary.txt
[task 2020-07-16T01:26:06.705Z] + NUM_UNNECESSARY=1118
[task 2020-07-16T01:26:06.705Z] ++ grep -c '^Dropped CFG' /builds/worker/workspace/analysis/build_xgill.log
[task 2020-07-16T01:26:06.707Z] + NUM_DROPPED=0
[task 2020-07-16T01:26:06.707Z] ++ perl -lne 'print $1 if m!found (\d+)/\d+ allowed errors!' /builds/worker/workspace/analysis/heapWriteHazards.txt
[task 2020-07-16T01:26:06.708Z] + NUM_WRITE_HAZARDS=0
[task 2020-07-16T01:26:06.708Z] ++ grep -c '^Function.*expected hazard.*but none were found' /builds/worker/workspace/analysis/rootingHazards.txt
[task 2020-07-16T01:26:06.709Z] + NUM_MISSING=0
[task 2020-07-16T01:26:06.709Z] + set +x
[task 2020-07-16T01:26:06.709Z] TinderboxPrint: rooting hazards<br/>1
[task 2020-07-16T01:26:06.709Z] TinderboxPrint: (unsafe references to unrooted GC pointers)<br/>74
[task 2020-07-16T01:26:06.709Z] TinderboxPrint: (unnecessary roots)<br/>1118
[task 2020-07-16T01:26:06.709Z] TinderboxPrint: missing expected hazards<br/>0
[task 2020-07-16T01:26:06.709Z] TinderboxPrint: heap write hazards<br/>0
[task 2020-07-16T01:26:06.711Z] TEST-UNEXPECTED-FAIL | hazards | unrooted 'oldHook' of type 'JSObject*' live across GC call at js/src/debugger/Debugger.cpp:4157
[task 2020-07-16T01:26:06.711Z] TEST-UNEXPECTED-FAIL | hazards | 1 rooting hazards detected
[task 2020-07-16T01:26:06.711Z] TinderboxPrint: documentation<br/><a href='https://wiki.mozilla.org/Javascript:Hazard_Builds#Diagnosing_a_rooting_hazards_failure'>static rooting hazard analysis failures</a>, visit "Inspect Task" link for hazard details
[task 2020-07-16T01:26:06.711Z] + onexit
[task 2020-07-16T01:26:06.711Z] + grab_artifacts /builds/worker/workspace/analysis /builds/worker/artifacts

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309940997&repo=autoland&lineNumber=2942

[task 2020-07-16T01:12:19.588Z] In file included from /builds/worker/checkouts/gecko/js/src/debugger/Script.h:14:0,
[task 2020-07-16T01:12:19.588Z]                  from /builds/worker/checkouts/gecko/js/src/debugger/Script-inl.h:10,
[task 2020-07-16T01:12:19.588Z]                  from /builds/worker/checkouts/gecko/js/src/debugger/Script.cpp:7:
[task 2020-07-16T01:12:19.588Z] /builds/worker/checkouts/gecko/js/src/debugger/Debugger.h:1123:27: error: inline function 'static js::Debugger* js::Debugger::fromJSObject(const JSObject*)' used but never defined [-Werror]
[task 2020-07-16T01:12:19.588Z]    static inline Debugger* fromJSObject(const JSObject* obj);
[task 2020-07-16T01:12:19.588Z]                            ^~~~~~~~~~~~
[task 2020-07-16T01:12:19.699Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o ustrcase_locale.o -c  -I/builds/worker/workspace/obj-spider/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DU_COMMON_IMPLEMENTATION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_HIDE_OBSOLETE_UTF_OLD_H=1 -DUCONFIG_NO_LEGACY_CONVERSION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DU_CHARSET_IS_UTF8 -DUNISTR_FROM_CHAR_EXPLICIT=explicit -DUNISTR_FROM_STRING_EXPLICIT=explicit -DU_ENABLE_DYLOAD=0 -DU_DEBUG=1 -I/builds/worker/checkouts/gecko/config/external/icu/common -I/builds/worker/workspace/obj-spider/config/external/icu/common -I/builds/worker/checkouts/gecko/intl/icu/source/i18n -I/builds/worker/workspace/obj-spider/dist/include -I/builds/worker/workspace/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Werror=implicit-function-declaration -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Wno-deprecated-declarations -Wno-type-limits -Wno-unused-but-set-variable -Wno-unused-function -Wno-sign-compare -Wno-maybe-uninitialized -frtti  -MD -MP -MF .deps/ustrcase_locale.o.pp   /builds/worker/checkouts/gecko/intl/icu/source/common/ustrcase_locale.cpp
[task 2020-07-16T01:12:19.699Z] config/external/icu/common/ustrenum.o
[task 2020-07-16T01:12:19.978Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o plurfmt.o -c  -I/builds/worker/workspace/obj-spider/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DU_I18N_IMPLEMENTATION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_HIDE_OBSOLETE_UTF_OLD_H=1 -DUCONFIG_NO_LEGACY_CONVERSION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DU_CHARSET_IS_UTF8 -DUNISTR_FROM_CHAR_EXPLICIT=explicit -DUNISTR_FROM_STRING_EXPLICIT=explicit -DU_ENABLE_DYLOAD=0 -DU_DEBUG=1 -I/builds/worker/checkouts/gecko/config/external/icu/i18n -I/builds/worker/workspace/obj-spider/config/external/icu/i18n -I/builds/worker/checkouts/gecko/intl/icu/source/common -I/builds/worker/workspace/obj-spider/dist/include -I/builds/worker/workspace/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Werror=implicit-function-declaration -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -frtti  -MD -MP -MF .deps/plurfmt.o.pp   /builds/worker/checkouts/gecko/intl/icu/source/i18n/plurfmt.cpp
[task 2020-07-16T01:12:19.978Z] config/external/icu/i18n/plurrule.o
[task 2020-07-16T01:12:20.257Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o ustrenum.o -c  -I/builds/worker/workspace/obj-spider/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DU_COMMON_IMPLEMENTATION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_HIDE_OBSOLETE_UTF_OLD_H=1 -DUCONFIG_NO_LEGACY_CONVERSION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DU_CHARSET_IS_UTF8 -DUNISTR_FROM_CHAR_EXPLICIT=explicit -DUNISTR_FROM_STRING_EXPLICIT=explicit -DU_ENABLE_DYLOAD=0 -DU_DEBUG=1 -I/builds/worker/checkouts/gecko/config/external/icu/common -I/builds/worker/workspace/obj-spider/config/external/icu/common -I/builds/worker/checkouts/gecko/intl/icu/source/i18n -I/builds/worker/workspace/obj-spider/dist/include -I/builds/worker/workspace/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Werror=implicit-function-declaration -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Wno-deprecated-declarations -Wno-type-limits -Wno-unused-but-set-variable -Wno-unused-function -Wno-sign-compare -Wno-maybe-uninitialized -frtti  -MD -MP -MF .deps/ustrenum.o.pp   /builds/worker/checkouts/gecko/intl/icu/source/common/ustrenum.cpp
[task 2020-07-16T01:12:20.258Z] config/external/icu/common/ustrfmt.o
[task 2020-07-16T01:12:20.705Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o ustrfmt.o -c  -I/builds/worker/workspace/obj-spider/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DU_COMMON_IMPLEMENTATION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_HIDE_OBSOLETE_UTF_OLD_H=1 -DUCONFIG_NO_LEGACY_CONVERSION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DU_CHARSET_IS_UTF8 -DUNISTR_FROM_CHAR_EXPLICIT=explicit -DUNISTR_FROM_STRING_EXPLICIT=explicit -DU_ENABLE_DYLOAD=0 -DU_DEBUG=1 -I/builds/worker/checkouts/gecko/config/external/icu/common -I/builds/worker/workspace/obj-spider/config/external/icu/common -I/builds/worker/checkouts/gecko/intl/icu/source/i18n -I/builds/worker/workspace/obj-spider/dist/include -I/builds/worker/workspace/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Werror=implicit-function-declaration -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Wno-deprecated-declarations -Wno-type-limits -Wno-unused-but-set-variable -Wno-unused-function -Wno-sign-compare -Wno-maybe-uninitialized -frtti  -MD -MP -MF .deps/ustrfmt.o.pp   /builds/worker/checkouts/gecko/intl/icu/source/common/ustrfmt.cpp
[task 2020-07-16T01:12:20.705Z] config/external/icu/common/ustring.o
[task 2020-07-16T01:12:20.986Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o plurrule.o -c  -I/builds/worker/workspace/obj-spider/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DU_I18N_IMPLEMENTATION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_HIDE_OBSOLETE_UTF_OLD_H=1 -DUCONFIG_NO_LEGACY_CONVERSION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DU_CHARSET_IS_UTF8 -DUNISTR_FROM_CHAR_EXPLICIT=explicit -DUNISTR_FROM_STRING_EXPLICIT=explicit -DU_ENABLE_DYLOAD=0 -DU_DEBUG=1 -I/builds/worker/checkouts/gecko/config/external/icu/i18n -I/builds/worker/workspace/obj-spider/config/external/icu/i18n -I/builds/worker/checkouts/gecko/intl/icu/source/common -I/builds/worker/workspace/obj-spider/dist/include -I/builds/worker/workspace/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Werror=implicit-function-declaration -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -frtti  -MD -MP -MF .deps/plurrule.o.pp   /builds/worker/checkouts/gecko/intl/icu/source/i18n/plurrule.cpp
[task 2020-07-16T01:12:20.987Z] config/external/icu/i18n/quantityformatter.o
[task 2020-07-16T01:12:21.015Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o ustring.o -c  -I/builds/worker/workspace/obj-spider/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DU_COMMON_IMPLEMENTATION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_HIDE_OBSOLETE_UTF_OLD_H=1 -DUCONFIG_NO_LEGACY_CONVERSION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DU_CHARSET_IS_UTF8 -DUNISTR_FROM_CHAR_EXPLICIT=explicit -DUNISTR_FROM_STRING_EXPLICIT=explicit -DU_ENABLE_DYLOAD=0 -DU_DEBUG=1 -I/builds/worker/checkouts/gecko/config/external/icu/common -I/builds/worker/workspace/obj-spider/config/external/icu/common -I/builds/worker/checkouts/gecko/intl/icu/source/i18n -I/builds/worker/workspace/obj-spider/dist/include -I/builds/worker/workspace/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Werror=implicit-function-declaration -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Wno-deprecated-declarations -Wno-type-limits -Wno-unused-but-set-variable -Wno-unused-function -Wno-sign-compare -Wno-maybe-uninitialized -frtti  -MD -MP -MF .deps/ustring.o.pp   /builds/worker/checkouts/gecko/intl/icu/source/common/ustring.cpp
[task 2020-07-16T01:12:21.016Z] config/external/icu/common/ustrtrns.o
[task 2020-07-16T01:12:21.912Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o ustrtrns.o -c  -I/builds/worker/workspace/obj-spider/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DU_COMMON_IMPLEMENTATION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_HIDE_OBSOLETE_UTF_OLD_H=1 -DUCONFIG_NO_LEGACY_CONVERSION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DU_CHARSET_IS_UTF8 -DUNISTR_FROM_CHAR_EXPLICIT=explicit -DUNISTR_FROM_STRING_EXPLICIT=explicit -DU_ENABLE_DYLOAD=0 -DU_DEBUG=1 -I/builds/worker/checkouts/gecko/config/external/icu/common -I/builds/worker/workspace/obj-spider/config/external/icu/common -I/builds/worker/checkouts/gecko/intl/icu/source/i18n -I/builds/worker/workspace/obj-spider/dist/include -I/builds/worker/workspace/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Werror=implicit-function-declaration -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Wno-deprecated-declarations -Wno-type-limits -Wno-unused-but-set-variable -Wno-unused-function -Wno-sign-compare -Wno-maybe-uninitialized -frtti  -MD -MP -MF .deps/ustrtrns.o.pp   /builds/worker/checkouts/gecko/intl/icu/source/common/ustrtrns.cpp
[task 2020-07-16T01:12:21.912Z] config/external/icu/common/utext.o
[task 2020-07-16T01:12:22.652Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o utext.o -c  -I/builds/worker/workspace/obj-spider/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DU_COMMON_IMPLEMENTATION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_HIDE_OBSOLETE_UTF_OLD_H=1 -DUCONFIG_NO_LEGACY_CONVERSION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DU_CHARSET_IS_UTF8 -DUNISTR_FROM_CHAR_EXPLICIT=explicit -DUNISTR_FROM_STRING_EXPLICIT=explicit -DU_ENABLE_DYLOAD=0 -DU_DEBUG=1 -I/builds/worker/checkouts/gecko/config/external/icu/common -I/builds/worker/workspace/obj-spider/config/external/icu/common -I/builds/worker/checkouts/gecko/intl/icu/source/i18n -I/builds/worker/workspace/obj-spider/dist/include -I/builds/worker/workspace/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Werror=implicit-function-declaration -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Wno-deprecated-declarations -Wno-type-limits -Wno-unused-but-set-variable -Wno-unused-function -Wno-sign-compare -Wno-maybe-uninitialized -frtti  -MD -MP -MF .deps/utext.o.pp   /builds/worker/checkouts/gecko/intl/icu/source/common/utext.cpp
[task 2020-07-16T01:12:22.652Z] config/external/icu/common/utf_impl.o
[task 2020-07-16T01:12:23.249Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o quantityformatter.o -c  -I/builds/worker/workspace/obj-spider/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DU_I18N_IMPLEMENTATION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_HIDE_OBSOLETE_UTF_OLD_H=1 -DUCONFIG_NO_LEGACY_CONVERSION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DU_CHARSET_IS_UTF8 -DUNISTR_FROM_CHAR_EXPLICIT=explicit -DUNISTR_FROM_STRING_EXPLICIT=explicit -DU_ENABLE_DYLOAD=0 -DU_DEBUG=1 -I/builds/worker/checkouts/gecko/config/external/icu/i18n -I/builds/worker/workspace/obj-spider/config/external/icu/i18n -I/builds/worker/checkouts/gecko/intl/icu/source/common -I/builds/worker/workspace/obj-spider/dist/include -I/builds/worker/workspace/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Werror=implicit-function-declaration -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -frtti  -MD -MP -MF .deps/quantityformatter.o.pp   /builds/worker/checkouts/gecko/intl/icu/source/i18n/quantityformatter.cpp
[task 2020-07-16T01:12:23.249Z] config/external/icu/i18n/rbnf.o
[task 2020-07-16T01:12:23.455Z] cc1plus: all warnings being treated as errors
[task 2020-07-16T01:12:23.725Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o utf_impl.o -c  -I/builds/worker/workspace/obj-spider/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DU_COMMON_IMPLEMENTATION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_HIDE_OBSOLETE_UTF_OLD_H=1 -DUCONFIG_NO_LEGACY_CONVERSION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DU_CHARSET_IS_UTF8 -DUNISTR_FROM_CHAR_EXPLICIT=explicit -DUNISTR_FROM_STRING_EXPLICIT=explicit -DU_ENABLE_DYLOAD=0 -DU_DEBUG=1 -I/builds/worker/checkouts/gecko/config/external/icu/common -I/builds/worker/workspace/obj-spider/config/external/icu/common -I/builds/worker/checkouts/gecko/intl/icu/source/i18n -I/builds/worker/workspace/obj-spider/dist/include -I/builds/worker/workspace/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Werror=implicit-function-declaration -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Wno-deprecated-declarations -Wno-type-limits -Wno-unused-but-set-variable -Wno-unused-function -Wno-sign-compare -Wno-maybe-uninitialized -frtti  -MD -MP -MF .deps/utf_impl.o.pp   /builds/worker/checkouts/gecko/intl/icu/source/common/utf_impl.cpp
[task 2020-07-16T01:12:23.726Z] config/external/icu/common/util.o
[task 2020-07-16T01:12:23.827Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o util.o -c  -I/builds/worker/workspace/obj-spider/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DU_COMMON_IMPLEMENTATION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_HIDE_OBSOLETE_UTF_OLD_H=1 -DUCONFIG_NO_LEGACY_CONVERSION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DU_CHARSET_IS_UTF8 -DUNISTR_FROM_CHAR_EXPLICIT=explicit -DUNISTR_FROM_STRING_EXPLICIT=explicit -DU_ENABLE_DYLOAD=0 -DU_DEBUG=1 -I/builds/worker/checkouts/gecko/config/external/icu/common -I/builds/worker/workspace/obj-spider/config/external/icu/common -I/builds/worker/checkouts/gecko/intl/icu/source/i18n -I/builds/worker/workspace/obj-spider/dist/include -I/builds/worker/workspace/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Werror=implicit-function-declaration -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Wno-deprecated-declarations -Wno-type-limits -Wno-unused-but-set-variable -Wno-unused-function -Wno-sign-compare -Wno-maybe-uninitialized -frtti  -MD -MP -MF .deps/util.o.pp   /builds/worker/checkouts/gecko/intl/icu/source/common/util.cpp
[task 2020-07-16T01:12:23.827Z] config/external/icu/common/utrace.o
[task 2020-07-16T01:12:23.878Z] /builds/worker/checkouts/gecko/config/rules.mk:746: recipe for target 'Script.o' failed
[task 2020-07-16T01:12:23.878Z] make[3]: *** [Script.o] Error 1
[task 2020-07-16T01:12:23.878Z] make[3]: Leaving directory '/builds/worker/workspace/obj-spider/js/src/debugger'
[task 2020-07-16T01:12:23.878Z] /builds/worker/checkouts/gecko/config/recurse.mk:72: recipe for target 'js/src/debugger/target-objects' failed
[task 2020-07-16T01:12:23.878Z] make[2]: *** [js/src/debugger/target-objects] Error 2
[task 2020-07-16T01:12:23.878Z] make[2]: *** Waiting for unfinished jobs....

Pushed by loganfsmyth@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d7f0912ee1f4
Part 1: Explicitly access owner slot for debugger child types. r=arai
https://hg.mozilla.org/integration/autoland/rev/a46fd674d025
Part 2: Avoid direct getPrivate usage on debugger children. r=arai

https://hg.mozilla.org/mozilla-central/rev/d7f0912ee1f4
https://hg.mozilla.org/mozilla-central/rev/a46fd674d025

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: