1652646 - Use nsIFrame::IsGridItem() and IsFlexItem() to replace equivalent conditions

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

We have a few places in our codebase that can use nsIFrame::IsGridItem() or nsIFrame::IsFlexItem() directly.

For example:
https://searchfox.org/mozilla-central/rev/89814940895946b48b4c04c702efd2c676ec8e7e/layout/generic/nsContainerFrame.cpp#2420-2423,2425

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1652646 Part 1 - Use nsIFrame::IsGridItem() whenever possible.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1652646 Part 2 - Use nsIFrame::IsFlexItem() whenever possible.

The only possible behavior change is in
nsIFrame::MarkIntrinsicISizesDirty(). Before this patch, we clear
CachedFlexItemData for every child frame under nsFlexContainerFrame.
However, only flex items can have cache, so we can use IsFlexItem() to
replace the usage.

Depends on D83453

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddf16c9e09fc
Part 1 - Use nsIFrame::IsGridItem() whenever possible. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/d0d053e0ccc3
Part 2 - Use nsIFrame::IsFlexItem() whenever possible. r=dholbert

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ddf16c9e09fc
https://hg.mozilla.org/mozilla-central/rev/d0d053e0ccc3