1652713 - Handle connection errors with ECH and HTTPSSVC

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P2)

Description

[Dragana Damjanovic [:dragana]]

If a connection to SvcDomainName with a echconfig fails, Firefox should retry with a different SvcDomainName.

If all SvcDomainNames advertise a echconfig, Firefox should never fall back to a connection to the origin server. Firefox should try all available SvcDomainNames. We should have a pref that allows fallback to a connection to the origin server directly. We may need to slowly rollout the strict no-fallback-to origin policy. If the pref is disable the fallback should be the same as in the following case.

If there are SvcDomainNames that do not advertise a echconfig, Firefox should try min(MAX_ECH_TRY, <number of available SvcDomainNames with echconfig>) configurations and afterwards connect to the origin directly.

Let MAX_ECH_TRY be 1.

The fallback mechanism should be executed if the original transaction has been canceled.

Comment 1

[Dragana Damjanovic [:dragana]]

(In reply to Dragana Damjanovic [:dragana] from comment #0)

The fallback mechanism should be executed if the original transaction has been canceled.

this sentence should be:
The fallback mechanism should NOT be executed if the original transaction has been canceled.

Comment 2

[Dragana Damjanovic [:dragana]]

I forgot to add:
a server may reject ech and return a new echconfig that should be used for a new transport connection. In this case, a new nsHttpconnectionInfo with the same RouteHost and RoutePort and the new echconfig should be created. The new nsHttpconnectionInfo should be used to create a new transport connection instead of using another SvcDomainName.

We will need to coordinate with the nss team to create a API.

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1652713 - Implement fallback mechanism when echConfig is enabled, r=dragana

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/395117cd7b25
Implement fallback mechanism when echConfig is enabled, r=dragana,necko-reviewers

Comment 5

[Dorel Luca [:dluca]]

Backed out 5 changesets (bug 1652717, bug 1665878, bug 1666620, bug 1652713) for XPCshell failures in components/migration/tests/unit/xpcshell.ini. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317794277&repo=autoland&lineNumber=3802

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=6322b86e1df42a2d468a134d6580b4a5db746a9f&selectedTaskRun=SQF6HSGCTWOZovkxOvQIrg.0

Backout:
https://hg.mozilla.org/integration/autoland/rev/04e0cdc282c235224d89ec00908c6af2e7341032

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bde69d944812
Implement fallback mechanism when echConfig is enabled, r=dragana,necko-reviewers

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bde69d944812