1652788 - Preemptively fix unified bustage in layout/base, layout/generic, layout/printing

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Daniel Holbert [:dholbert]]

The directories layout/{generic,base,printing} don't quite build right now, if I disable unification (by doing s/UNIFIED_SOURCES/SOURCES/ in their moz.build files).

The layout/generic issue in particular is causing me trouble in bug 1652278 where I'm adding a new .cpp file, which rebuckets the unified compilation units.

I'll preemptively fix up the unified bustage here.

Comment 1

[Daniel Holbert [:dholbert]]

Here's the build error in layout/base:

layout/base/LayoutTelemetryTools.cpp:54:3: error: use of undeclared identifier 'PodZero'
   PodZero(&mReqsPerFlush);

---> Fixing by including the relevant header (mozilla/PodOperations.h)

Here's the build error in layout/generic:

layout/generic/nsILineIterator.h:59:12: error: field has incomplete type 'nsRect'
     nsRect mLineBounds;

This header needs the actual nsRect type definition.
---> Fixing by upgrading the forward-decl to an include (and dropping the existing nsPoint.h include since nsRect.h includes nsPoint.h and it's not-crazy to depend on that, since they're so intertwined)

Here are the build errors in layout/printing:

layout/printing/nsPrintObject.cpp:86:20: error: use of undeclared identifier 'Reversed'; did you mean 'mozilla::Reversed'?
layout/printing/nsPrintObject.cpp:120:48: error: use of undeclared identifier 'SelectionType'; did you mean 'mozilla::SelectionType'?
layout/printing/nsPrintObject.cpp:152:45: error: use of undeclared identifier 'IgnoreErrors'; did you mean 'mozilla::IgnoreErrors'?
layout/printing/nsPrintObject.cpp:253:14: error: no template named 'UniquePtr'

...and also layout/printing/nsPrintObject.cpp:112:9: error: unknown type name 'Selection'; did you mean 'mozilla::dom::Selection'?

---> Fixed the first thing by adding using namespace mozilla, and the second thing adding a type-specific using mozilla::dom::Selection since this file seems to prefer that for stuff in mozilla::dom (and it was nearly complete on those using decls, except for this one type)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1652788: Preemptively fix unified build bustage in layout/{base,generic,printing}. r?TYLin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdd91446cdfb
Preemptively fix unified build bustage in layout/{base,generic,printing}. r=TYLin

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/fdd91446cdfb